feat: add build.rs compatiblity#48
Open
stringhandler wants to merge 2 commits intoBlockstreamResearch:masterfrom
Open
feat: add build.rs compatiblity#48stringhandler wants to merge 2 commits intoBlockstreamResearch:masterfrom
stringhandler wants to merge 2 commits intoBlockstreamResearch:masterfrom
Conversation
Collaborator
|
Ok, that's a good idea as currently we need to run |
Author
|
It's a common pattern to have it in its own crate so that it's only referenced at build time through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Introduces a new user-facing
smplx-buildcrate so that projects can generate Simplex contract artifacts automatically via Cargo's build script mechanism, without requiring thesimplexCLI to be installed.Motivation
I pulled the Simplicity lending demo but it doesn't build with a simple
cargo build. This PR allows users to add tobuild.rsand[build-dependencies]inCargo.toml, similar totonic-buildorprost-build.Testing
You can test this by referencing the crate
smplx-buildunder[build-dependencies]inCargo.tomland adding this to yourbuild.rs(create if doesn't exist):Then
cargo buildwill regeneratesrc/artifactsif the files have changed.In addition, I've added some extra config builders for people who don't want to use
Simplex.toml. These can be easily removed if they bug anyone, but seemed good to add for completeness.Examples
Notes
The existing internal codegen library is renamed
smplx-build-internalto make room for the new public crate, which wraps it with a proper build.rs-oriented API