docs: say that operators hold the bypass permissions by default - #66
Merged
Conversation
The upgrade rehearsal showed an operator teleporting with no countdown on a server whose config sets a delay, with nothing in the release notes to explain it. sh2.admin defaults to op and grants all three bypass nodes as children. This is v1 parity rather than a new rule: v1's homes.config_bypass was a child of homes.*, which also defaulted to op, and it skipped the teleport delay in GoHome and the blacklist and home limit in SetHome and UpdateHome. So a server migrating from v1 sees no change. A server already on 1.2.2 does, because 1.2.2 had no bypass nodes at all, and that is the case this sentence covers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during the existing-install upgrade rehearsal on 2026-08-18. Edits the pending
tidy-wolves-travelchangeset only. No code change.What happened
On an upgraded server an operator teleported with no countdown, on a server whose
config.ymlsetsdelay: 7. Deopping the same player produced the 7 second countdown, the cancel on move, and a refusal on a home in a blacklisted world. So the feature works; the operator simply is not subject to it.sh2.admindefaults toopand grantssh2.bypass-max-homes,sh2.bypass-blacklistandsh2.bypass-teleport-delayas children. Nothing in the release notes said so.Why no code change
The first instinct was to drop
sh2.bypass-teleport-delayfrom the admin bundle. That would have been wrong.Set Homes v1 1.3.0 has
homes.config_bypass, a child ofhomes.*which also defaults toop. Read from the shipped jar, it gates:GoHometp-delayscheduler, at two call sites, and the cooldownSetHomemax-homeslimitUpdateHomeThe same three things. So operators bypassing these is v1 parity, not a new rule, and the README already documents the mapping at lines 295 and 301 along with
sh2.adminbeing OP-default at line 118. Changing the default would make v2 diverge from v1 for the exact audience the shared-listing consolidation is aimed at.Only the 1.2.2 to 2.0.0 path sees a behavior change, because 1.2.2 had no bypass nodes at all. That is the case this sentence covers.
The added text
It reassures a migrating v1 admin that nothing changed, and warns an upgrading 1.2.2 admin that something did.
Verification
bash scripts/release.sh check: 17 changesets parse, README can take the changelog.