chore: use American spelling in user-facing text - #65
Merged
Conversation
The migration rehearsal surfaced British spellings in text server owners actually read: the import report, two teleport messages, the config file comments and the README. House style is American English, so they now read capitalization, color and canceled. Also adds a missing word to the block printed when a Set Homes v1 jar is found alongside this one. It read "Nothing ever writes to it, but is needed for migrating homes to v2". The generated changelog entries keep the spelling they were published with, since they are a record of past releases rather than living text. Bukkit's own isCancelled spelling is untouched, and comments describing event cancellation keep it to match the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during the v1 to v2 migration rehearsal on 2026-08-18. The import report and several other messages server owners read used British spellings, against house style.
What changed
SetHomesV1Importer.javaUserError.java+default-config.ymlmovedWhileTeleportingandunsafeHomenow say "canceled"default-config.yml'&' colour codesREADME.mdSetHomesTwo.javaThe collision block read "Nothing ever writes to it, but is needed for migrating homes to v2". It now reads "but it is needed".
What was deliberately left alone
isCancelledandsetCancelled, which are Bukkit's own API spelling, along with the internalOUTCOME_CANCELLED_MOVEDconstant and comments describing event cancellation, which match the API deliberately.HomeNameValidator.normaliseand its call sites. It is an existing identifier rather than user-facing text, so renaming it is a separate call.Verification
mvn test: 387 tests, 0 failures, 0 errors, 0 skipped, unchanged before and after.config.ymlis never rewritten, so a server that has already customized these messages keeps exactly what it set. Only new installs get the corrected defaults.