ci: publish to the Set Homes listing as SetHomes.V<x>.jar - #64
Merged
Conversation
Point the release at BukkitDev project 312833, the listing v1 servers already watch, so v2 arrives as the update on the page they know rather than a download they have to go and find. The published artifact and the GitHub Release become SetHomes.V<x>.jar and "Set Homes V<x>". The script comment named the two project ids the wrong way round; that is corrected. Also refuse to publish anything below 2.0.0. v1 last shipped 1.3.1 and the pom is at 1.2.2, so until the major bump is made by hand at promotion a push to master would offer those servers a lower version than they are running. The guard turns that into a failed release step instead of a public downgrade, and sits beside the existing game-version sanity check. plugin.yml's name, the data folder and the Maven artifact are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55.
Points the release pipeline at BukkitDev project 312833, the existing Set Homes listing, so every v1 server is offered v2 as an update on the page it already watches. The published jar and the GitHub Release become
SetHomes.V<x>.jarandSet Homes V<x>.scripts/publish-bukkitdev.shhad a comment naming the two project ids the wrong way round, which is corrected.The extra bit: a version floor
Not in the issue's change table, added after reading the release path.
v1 last shipped 1.3.1 and
pom.xmlis at 1.2.2.release.ymlpublishes on any push tomaster, and the 2.0.0 bump is a by-hand item still open on #41 because changesets in this repo are alwayspatch. So repointing the listing on its own makes it possible to publish "Set Homes V1.2.3" onto the v1 listing, offered as an update to servers running 1.3.1.publish-bukkitdev.shnow refuses anything below 2.0.0, in the same style as the game-version count check right above it. Promotingdevbefore the manual major bump becomes a failed release step instead of a public downgrade.That failure mode is not hypothetical. Running the test harness before this change, the
VERSION=1.2.3case ran to completion and printedBukkitDev upload succeeded (HTTP 200).Verification
scripts/test-publish-bukkitdev.sh: 6 passed / 4 failed before, 10 passed / 0 failed after. Two new cases cover the guard: a sub-2.0.0 run exits non-zero, and records no curl call at all.0.xand1.xrefuse;2.0.0and10.0.0pass (1.*needs a literal dot, so10.0.0is not caught).mvn test: 387 tests, 0 failures, 0 errors, 0 skipped, unchanged before and after.grep -rn "913275\|SetHomesTwo\.V\|SetHomesTwo V" .github/ scripts/returns nothing.Still owed, since it needs Actions: a Release workflow
dry_rundispatch confirming project 312833, jarSetHomes.V<x>.jar, titleSet Homes V<x>.Out of scope
plugin.yml'sname:, theplugins/SetHomesTwo/data folder and the Maven artifact name are all unchanged, per the issue. The README rename, the 2.0.0 bump, retitling 312833 and retiring 913275 stay on #41.