Skip to content

Fix AROS64 XADOpen and CLI crashes#139

Merged
midwan merged 2 commits into
masterfrom
issue-90-aros64-xad-cli
May 16, 2026
Merged

Fix AROS64 XADOpen and CLI crashes#139
midwan merged 2 commits into
masterfrom
issue-90-aros64-xad-cli

Conversation

@midwan
Copy link
Copy Markdown
Collaborator

@midwan midwan commented May 16, 2026

Summary

  • fix AROS x86_64 DOpus ARexx message metadata so XADOpen no longer dereferences a truncated stem-list pointer in FreeRexxMsgEx
  • build the internal CLI console name without RawDoFmt string varargs on AROS x86_64
  • add source-level regression tests for both failure modes

Validation

  • python3 -m unittest source.Program.tests.test_cli_console_cleanup source.Library.tests.test_rexx_aros64_tracking source.Modules.xadopus.tests.test_aros64_callback_layout
  • find source -path '*/tests/test*.py' -print0 | xargs -0 -n1 python3
  • podman run --rm -v /home/midwan/Github/dopus5:/work --workdir /work/source midwan/aros-compiler:x86_64-aros make x86_64-aros all debug=yes

@midwan midwan linked an issue May 16, 2026 that may be closed by this pull request
@midwan midwan marked this pull request as ready for review May 16, 2026 14:47
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a3614a4f4a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread source/Program/function_cli.c Outdated
@midwan midwan merged commit 4aa2011 into master May 16, 2026
15 checks passed
@midwan midwan deleted the issue-90-aros64-xad-cli branch May 16, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AROS 64bit - XADOpen, File Types GUI and CLI Error

1 participant