feat(desktop): port SnapShots onto V2 and native attachment views - #309
Merged
Merged
Conversation
github-actions
Bot
added
size:XXL
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS users can now capture their foreground window into an unsent draft with both Shift keys or a saved custom shortcut. SnapShots include permission setup with restart resume, optional app text/controls, source identity, sound and motion-aware capture feedback. Captures remain queued until the composer has saved them successfully, including quota-failure retries without duplicate attachments.
Manually ported upstream
299404a754f52c02c69634528d8856b3c93b378cand reviewed follow-ups throughd29c56a5c404cb0f58d3b2ac41762fa0d0ac28d4. The fork's V2 start/steering services append bounded captured-window data; metadata survives unified attachment uploads, drafts, compression and stashes. Swift displays the source app and inspectable text/tree details. Existing iOS Photos/Camera/Files/share intake stays its capture entry point.The macOS ARM build omits Linux/Windows capture backends and their system-config installers. No V1 provider runtime or SQLite migration is imported. PATCH.md and user documentation describe the port.
Validation: full server suite 4,265 passed, 13 skipped, only two known PortScanner failures; focused capture queue, IPC, V2 and image tests; desktop/web/server/Expo configured compiler checks; lint with no errors; desktop production bundles including the accessibility worker; Swift app/test compile and two executed host Swift contract tests. Contract fixture checks pass. No simulator/browser/UI launch or real capture/permission prompts, so visual and OS permission interaction verification remains manual. Native compile retains existing VoiceComposerCoordinator warnings.
Implemented with GPT-6 in the Codex harness.