Skip to content

sync: upstream e16b8b059c..0f602b3372 with native PR and image parity - #288

Open
Bl4ckBl1zZ wants to merge 2 commits into
mainfrom
sync/upstream-2026-09-10
Open

sync: upstream e16b8b059c..0f602b3372 with native PR and image parity#288
Bl4ckBl1zZ wants to merge 2 commits into
mainfrom
sync/upstream-2026-09-10

Conversation

@Bl4ckBl1zZ

@Bl4ckBl1zZ Bl4ckBl1zZ commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Manually ports upstream e16b8b059c9f5ff6dfed1addecffb831c6aee043..0f602b3372b300ae94084bd3fe7dbaadaa58ba3a (13 commits), then implements the four approved Swift parity features. Native users can search linked PRs, zoom image galleries, manage multiple explicit PR links, and review GitHub stack merges/rebases. Threads continue to run exclusively on orchestration V2.

Upstream disposition

Upstream Result
f0401c6290 PR-number/repository/URL search in web sidebar/command palette and Swift; searches every explicit V2 link.
8d8189e67d Web zoom/pan with original downloads; Swift pinch/pan, double-tap and accessible fit in existing galleries.
b7b3ef1e6f Web composer labels use available width; frozen Expo half excluded.
addfb1390e PR diff counts at the title’s trailing edge.
385cc0a4c6 Touch-visible user-message copy controls; assistant controls already existed.
d1eeb16247 Terminal middle-click pastes its own selection while preserving VT mouse reporting and fork selection behavior.
0f602b3372 Zed remote SSH links and Electron allowlist.
afb84898be Partial V2/native port: atomic explicit multi-link updates, host/repository/number identity, JSON projection and conservative settlement. Automatic discovery/linking, tombstones, cached link snapshots and MCP linking remain deferred.
de37964db2 GitHub stack read/action backend and Swift navigation/confirmation; web/Expo stack panels remain deferred.
50f918c57a Already covered by V2 tool disclosures; no change needed.
75e4ceb964, 383cc40f4d Android layout/glass fixes excluded under the Expo freeze.
33242d0164 Restart-persistent summary/stack cache deferred with the missing V2 background discovery service.

Nine upstream commits are wholly or partly ported, one is already equivalent, two are intentionally dropped and one remains deferred. No blind merge or cherry-pick. The subsequent upstream blue/orange palette and legacy relink fix were read for the comparison but do not advance this sync marker.

Native and V2 behavior

  • thread.metadata.update adds/removes one explicit link at a time, up to 50. The primary field stays compatible with old clients; legacy edits preserve additional links. Both snapshot and live shells carry the collection. No migration or V1 import is added; upstream migration 050 remains excluded.
  • Swift gates editing on threadPullRequestsV2, searches all links and restarts status observations when links change. Incomplete reads cannot settle through either merge or inactivity. Web/Expo retain the primary-link UI and conservatively avoid automatic collection settlement; explicit settle still works.
  • pullRequests.stack and pullRequestStackActions enable native stack navigation and reviewed actions. Confirmation holds immutable revisions. The GitHub boundary revalidates membership/heads and branch permissions, reports partial rebase completion, and never rewrites the local checkout. Every reviewed PR cache entry is invalidated even after partial failure.
  • Image zoom preserves current/adjacent-page loading and original-byte exports. Fit/reset and fitted-size gallery swipes provide the reverse actions. No continuous animation.
  • PATCH.md and user/internal docs describe the exact scope and remaining differences.

Validation

  • Final server package suite: 3,725 passed, 2 failed, 13 skipped (348 files). Both failures are unchanged preview/PortScanner.test.ts TCP-probe tests, the same baseline failures as before this follow-up.
  • 136 focused server tests passed, including V1 import boundary, V2 projection persistence, PR service routing and GitHub stack safety.
  • 211 client-state tests and 4 shared PR identity/update tests passed. The preceding sync’s 233 focused web/desktop tests passed.
  • Full requested lint passed with zero errors; final changed-file lint passed.
  • Server, web and client-runtime typechecks passed; previous sync also checked desktop/contracts/shared.
  • iOS app and test targets built with build-for-testing. Host-side Swift decoding/round-trip and reviewed-layer checks passed against the generated server contract fixture.
  • Swift contract fixture --check and git diff --check passed.

No Simulator, browser or UI automation session was launched, as requested. The native tests compiled but were not executed. Before/after screenshots and gesture recordings are unavailable; live gesture and real GitHub stack mutation verification remain review limits.

Model: GPT-6. Harness: Codex in T3 Code.

@github-actions github-actions Bot added size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Sep 10, 2026
@Bl4ckBl1zZ Bl4ckBl1zZ changed the title sync: upstream e16b8b059c..0f602b3372 (13 commits) sync: upstream e16b8b059c..0f602b3372 with native PR and image parity Sep 10, 2026
@github-actions github-actions Bot added size:XXL and removed size:L labels Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant