sync: upstream e16b8b059c..0f602b3372 with native PR and image parity - #288
Open
Bl4ckBl1zZ wants to merge 2 commits into
Open
sync: upstream e16b8b059c..0f602b3372 with native PR and image parity#288Bl4ckBl1zZ wants to merge 2 commits into
Bl4ckBl1zZ wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually ports upstream
e16b8b059c9f5ff6dfed1addecffb831c6aee043..0f602b3372b300ae94084bd3fe7dbaadaa58ba3a(13 commits), then implements the four approved Swift parity features. Native users can search linked PRs, zoom image galleries, manage multiple explicit PR links, and review GitHub stack merges/rebases. Threads continue to run exclusively on orchestration V2.Upstream disposition
f0401c62908d8189e67db7b3ef1e6faddfb1390e385cc0a4c6d1eeb162470f602b3372afb84898bede37964db250f918c57a75e4ceb964,383cc40f4d33242d0164Nine upstream commits are wholly or partly ported, one is already equivalent, two are intentionally dropped and one remains deferred. No blind merge or cherry-pick. The subsequent upstream blue/orange palette and legacy relink fix were read for the comparison but do not advance this sync marker.
Native and V2 behavior
thread.metadata.updateadds/removes one explicit link at a time, up to 50. The primary field stays compatible with old clients; legacy edits preserve additional links. Both snapshot and live shells carry the collection. No migration or V1 import is added; upstream migration 050 remains excluded.threadPullRequestsV2, searches all links and restarts status observations when links change. Incomplete reads cannot settle through either merge or inactivity. Web/Expo retain the primary-link UI and conservatively avoid automatic collection settlement; explicit settle still works.pullRequests.stackandpullRequestStackActionsenable native stack navigation and reviewed actions. Confirmation holds immutable revisions. The GitHub boundary revalidates membership/heads and branch permissions, reports partial rebase completion, and never rewrites the local checkout. Every reviewed PR cache entry is invalidated even after partial failure.Validation
preview/PortScanner.test.tsTCP-probe tests, the same baseline failures as before this follow-up.build-for-testing. Host-side Swift decoding/round-trip and reviewed-layer checks passed against the generated server contract fixture.--checkandgit diff --checkpassed.No Simulator, browser or UI automation session was launched, as requested. The native tests compiled but were not executed. Before/after screenshots and gesture recordings are unavailable; live gesture and real GitHub stack mutation verification remain review limits.
Model: GPT-6. Harness: Codex in T3 Code.