chore(api): drop unused KMS dependency and config#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes AWS KMS remnants that were provisioned for photo encryption but never used. Photos are encrypted at rest by S3's default SSE-S3 (AES-256); after review we decided customer-managed KMS keys are not needed at this stage — they add per-request cost and an operational failure mode without a compliance driver. If that changes later, SSE-KMS is a bucket-level setting requiring no API code.
What's included
@aws-sdk/client-kms(never imported anywhere)kmsKeyIdentry fromaws.config.tsAWS_KMS_KEY_IDfrom.env.exampleNot in this PR (intentional)
ENCRYPTION_MASTER_KEY/encryption.config.tsandMAX_FILE_SIZEare also dead config from the same era (values never read) — candidates for a small follow-upTest plan
api/src,api/test, env files, orpackage.jsonnpm run build,npm test(265),npm run test:e2e(101),eslint,format:checkall green