[codex] Fix standard stableswap quote fee scaling#24
Open
caydyan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get-dxandget-dytotal swap fees from scaled token amountsget-dxagainstswap-y-for-xWhy
The read-only quote helpers compute AMM balances in scaled precision, but their total-fee inputs used the unscaled token amount. For mixed-decimal pairs this can make the quote path diverge from the executable swap path. In the USDA/sUSDT pool,
get-dxoverquotedu9999948020before the fix whileswap-y-for-xreturnedu9994998022for the sameu100000000USDA input.Validation
git diff --checkclarinet checkclarinet consoleconfirmedget-dxandswap-y-for-xnow both returnu9994998022for the mixed-decimal scenario aboveNote: the local environment does not have
deno, so the TypeScript Clarinet test was added but not executed here.