[codex] Lock standard stableswap minimum liquidity#22
Open
caydyan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
u1000LP tokens during standard stableswap pair creationWhy
The standard stableswap pool currently mints the entire initial LP supply to the creator, so the first LP can later burn all of their shares and fully empty the pool. Locking a small minimum LP supply follows the same protection added for the StackingDAO stableswap path and prevents total pool depletion.
Validation
git diff --checkclarinet checkclarinet consolecreate-pair path confirmed creator LPu1999999999999000, contract-locked LPu1000, and full creator withdrawal leavesbalance-x: u500,balance-y: u5,total-shares: u1000clarinet consoletiny initial liquidity path returns(err "err-initial-liquidity-too-low")Note: the local environment does not have
deno, so the TypeScript Clarinet tests were added but not executed here.