[codex] Allow exact standard stableswap bounds#21
Open
caydyan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR lets the standard
stableswap.claraccept exact user-provided lower bounds instead of requiring outputs to be strictly greater than the bound.Changed standard pool checks from
>to>=for:swap-x-for-ymin-y-amountswap-y-for-xmin-x-amountadd-liquiditymin-lp-amountwithdraw-liquiditymin-x-amountandmin-y-amountBecause the withdraw bound now accepts equality, I added an explicit
lp-amount > 0guard so a zero-LP no-op cannot pass with zero minimums.Why
A minimum output/slippage bound normally means "at least this amount." The previous strict comparisons rejected successful swaps, mints, and withdrawals when the realized amount matched the user bound exactly.
Validation
git diff --checkclarinet check(passes for all 12 contracts; existing warnings only)clarinet consolereplay for exact-boundswap-x-for-y, exact-boundswap-y-for-x, exact-boundadd-liquidity, and exact-boundwithdraw-liquidityNotes
I kept this scoped to the standard stableswap contract. The StackingDAO variant is covered separately in #18.