[codex] Reject zero StackingDAO convergence threshold#19
Open
caydyan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
change-convergence-threshold u0in the StackingDAO stableswap contract.Audit context
This addresses F-06 from the public ClankOS / AIBTC StackingDAO stableswap audit notes:
https://gist.github.com/ClankOS/61003f54ed834fdbc9be72fe95a314fa
The convergence loops check whether the Newton-Raphson delta is less than or equal to the configured threshold. Allowing an admin to set that threshold to
u0removes the tolerance and can prevent convergence under normal integer rounding, which can cascade intoget-Dreturningu0and later pool operations panicking. This PR rejectsu0at the setter boundary.Validation
git diff --checkclarinet checkpasses for all 12 contracts; existing repository warnings remain.change-convergence-threshold u0returns(err "err-invalid-convergence-threshold").change-convergence-threshold u1returns(ok true).