[codex] Expose same-multi swap spent amounts#17
Open
caydyan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-amount-spenttoswap-x-for-y-same-multiresponsesy-amount-spenttoswap-y-for-x-same-multiresponsesresults[].intotals and token balance deltasWhy
The same-token multi-swap helpers already aggregate output and per-hop
in/outresults, but their top-level response did not expose the aggregate input actually consumed. This makes partial-fill accounting harder for callers and integrators. The simple multi-swap entrypoints already return top-level input/output fields; this brings the same-multi helpers in line with that behavior.Validation
git diff --checkclarinet check contracts/dlmm-swap-router-v-1-1.clarpasses with the repo's existing warningsnpx vitest run tests/routers/swap-router.test.tsis currently blocked before tests execute by an existing trait-signature error:invalid signature for method get-pool-for-add regarding trait's specification <dlmm-pool-trait>