Tighten analytic validation before visual upgrades - #3
Draft
Biswajit1999 wants to merge 4 commits into
Draft
Biswajit1999 wants to merge 4 commits into
Biswajit1999 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this pass
This upgrade follows the research-led sequence: scientific claims and equations first, then reproducibility and validation, before any new interface animation or rendering.
Repository worked on
Biswajit1999/Cosmic-Lens-LabBranch
science-validation-tightening-20260706Changed files
python/tests/test_lensing_invariants.pydocs/validation.mddocs/science-audit-2026-07-06.mdREADME.mdScientific checks added
theta_plus + theta_minus = betatheta_plus * theta_minus = -theta_E^2beta = theta - theta_E^2 / theta|beta| = theta_E.beta -> -beta.Documentation tightened
Validation status
Not merged. This is a draft PR for review. The expected local validation command is:
I could inspect and update the repository through GitHub, but I did not run the test suite in a local checkout during this automation pass.
Next scientific gap
Add browser/Python parity fixtures: export one point-mass scene from the web app, recompute the same ray mapping in Python, and assert agreement away from the singular origin and critical curve.