Add analytic lensing validation contract - #2
Draft
Biswajit1999 wants to merge 4 commits into
Draft
Biswajit1999 wants to merge 4 commits into
Biswajit1999 wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a science-first validation contract before any UI/rendering upgrade.
Changed:
tools/validate_lensing_contract.pydocs/validation_contract.mddocs/validation.md.github/workflows/ci.ymlScientific checks added:
Validation command:
CI now runs the analytic contract after the existing Python validation tests.
No visual/interface changes are included in this PR. The next scientific gap is strict critical-curve/caustic validation, especially contour sign consistency and topology for point-mass + shear and softened elliptical models.