Move volume API calls to background thread and batch volume changes #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blocking API calls on the main thread could cause key presses to not be registered by the application when done in quick succession, such as when a scroll wheel was used. Batching volume increments done in quick succession (100ms by default) reduces the amount of API calls, avoiding throttling errors from Spotify. The batching delay is configured through a new config value, `batch_delay_ms`. Setting this to `0` disables the batching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocking API calls on the main thread could cause key presses to not be registered by the application when done in quick succession, such as when a scroll wheel was used.
Batching volume increments done in quick succession (100ms by default) reduces the amount of API calls, avoiding throttling errors from Spotify. The batching delay is configured through a new config value,
batch_delay_ms. Setting this to0disables the batching.