Conversation
|
Heads-up before this goes further: #414 (TSA-331) landed the same navigation on a different branch, as part of a batch of upload/ingest fixes. Sorry for the overlap — it wasn't scoped as TSA-282 work, so it wasn't obvious from the board. What overlaps. Both PRs rewrite The mechanism differs:
We went with polling because the navigation then doesn't depend on a long request staying alive — a timeout, a reconnect or a backgrounded tab would otherwise leave the user stranded on the upload screen. It also removes the need for the backend changes in this PR (and those belong to #281 anyway). What is NOT covered by #414 and should stay in this PR:
Suggested next step: let #414 land, then rebase this on top and keep only (1) and (2) — dropping the navigation effect, the |
|
Please review the new transition logic, remove the duplicate logic, and keep a few of your fixes. |
|
@RomanNabukhotniidev Done! I cleaned up the overlapping transition logic, removed the duplicates, and kept the ingestion error handling and preparation message fixes as suggested. The backend files come from issue #281 which already has a PR, so once it merges into |
|
make it ready for review if it done |
a0b47fb to
6befcd9
Compare
…6-transcripta into feat/TSA-282-straight-verification-page-after-start-processing
…6-transcripta into feat/TSA-282-straight-verification-page-after-start-processing
…6-transcripta into feat/TSA-282-straight-verification-page-after-start-processing
…cessing' of https://github.com/BinaryStudioAcademy/bsa-2026-transcripta into feat/TSA-282-straight-verification-page-after-start-processing
…6-transcripta into feat/TSA-282-straight-verification-page-after-start-processing
|
Hi @RomanNabukhotniidev, the PR is ready for review with all the changes suggested, now without the backend files. |
…6-transcripta into feat/TSA-282-straight-verification-page-after-start-processing
…r-start-processing
…cessing' of https://github.com/BinaryStudioAcademy/bsa-2026-transcripta into feat/TSA-282-straight-verification-page-after-start-processing
…6-transcripta into feat/TSA-282-straight-verification-page-after-start-processing
…r-start-processing
MatiStb
left a comment
There was a problem hiding this comment.
I reviewed the branch against main: both of Roman's comments are properly resolved (the hasVerifiedPages signal and the setTimeout → setInterval change), but the four blocking items are still untouched. The worst one is that /verify fetches the document once and never refreshes it, so with a large PDF you end up with pageCount = 0 frozen, the cursor stuck on page 1, and a dead ► button. On top of that there's the 60 s timeout that dumps you back on the document page (the old flow with the extra click), the failed ingest that doesn't keep you on the upload screen with the reason, and the POST /ingest still not awaited, whose error nobody sees because the middleware swallows it. Short version: the new flow works fine on small documents, but it breaks on the large ones — which is exactly the case in the ticket
…6-transcripta into feat/TSA-282-straight-verification-page-after-start-processing
|
Resolve conflicts, please |
…r-start-processing # Conflicts: # apps/frontend/src/pages/verification/verification.tsx
|
@IgnacioRB @MatiStb I merged The large-file problem is in the backend, not in this PR. The cursor jumped back. When ingest finished, the document reloaded and the cursor effect ran a second time, throwing the user from page 3 back to page 1. Now the cursor is initialised once per document. Mati's two other points are fixed: a failed ingest keeps you on the upload screen with the real reason ("Failed to read PDF. It may be corrupted"), and The 60 s timeout Ignacio was right about. Once
|
RomanNabukhotniidev
left a comment
There was a problem hiding this comment.
Merged main in and pushed the four fixes myself, then retested on a 3-page and a 120-page PDF: the verification screen opens with a real page count straight away, the cursor no longer jumps back when ingest finishes, and a failed ingest keeps the user on the upload screen with the actual reason. Lint and build are green.
@MatiStb your changes-requested is still standing and blocks the merge, please take another look when you can.
…cessing' of https://github.com/BinaryStudioAcademy/bsa-2026-transcripta into feat/TSA-282-straight-verification-page-after-start-processing
…6-transcripta into feat/TSA-282-straight-verification-page-after-start-processing
|
Hi, I’ve reviewed @MatiStb’s comments and @RomanNabukhotniidev’s changes. Thanks a lot for the backend adjustment to save the |
…r-start-processing
Closes #282
It will be on draft until PR #344 is merged into
mainbranch. Ignore the backend files since hey belong to the backend counterpart #281.Summary
Updated the document ingestion flow to navigate users directly from the upload screen to the verification workspace upon a successful POST /documents/:id/ingest call, eliminating unnecessary intermediate screens and extra clicks.
Previously, triggering process completion left the user on the document page where they had to watch a progress line and manually click "Resume at page 1" to begin working. Now, the user journey proceeds seamlessly into the verification view as soon as ingestion is completely successful with the first page. Also, if ingestion fails, the application redirects to the document page and clearly displays the failure reason.
Corresponding Redux slice reducers for ingest were wired up to correctly track state, and UI text anomalies during document preparation states were cleaned up.
Changes
Once you are on the document-new page and start the ingestion, instead of redirecting you directly to the document page, it will stay there showing loading progress and automatically take you to the verification screen once ready.
If ingestion fails and you are still on the document-new page, it will redirect you to the document page and display the error. If you navigate away while it's ingesting, you will access the document page instead manually to check if there is an error.
Updated the preparation/waiting message on the verification screen to accurately state that pages are currently being prepared, instead of falsely claiming that everything has already been verified. If you are on a page that is still being processed, it will automatically update once the transcription is ready.
UI changes