TSA-147: Allow a page to be confirmed again after undo - #343
Merged
Merged
Conversation
MatiStb
requested review from
RomanNabukhotniidev,
anjoanka,
arturobdev and
illiaboiko
September 20, 2026 22:02
RomanNabukhotniidev
approved these changes
Sep 21, 2026
anjoanka
approved these changes
Sep 21, 2026
Collaborator
|
Tested locally.
Not covered in my testing: lexicon counters, reopening a Three things worth discussing are in the inline comments (undo of an older page, a stale duplicate undo, and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #147
Related to #56
Related to #266
Frontend consumer: #267
Offline queue scope: #143
Summary
Implements the backend support required to confirm a page again after it has been undone.
The verification history now distinguishes a genuine replay from a new verification attempt after undo.
What Changed
page_event.attemptwith a default value of0.page_event_onceto include:page_idtranscription_ideventattemptundoevents to the page history.POST /api/v1/pages/:id/undoendpoint.transcribed;verified_byandverified_at;donedocument asprocessing;200without creating duplicate events.Acceptance Criteria
confirmed.undoevent.Validation
Static Validation
The following checks passed:
npm run lintls-linttsctsc-aliasgit diff --checkDatabase Validation
Executed:
Result:
Manual API Validation
The flow was tested against the running backend with PostgreSQL, Redis, and MinIO:
Expected and observed history:
The final page state was:
The replay returned
200and did not create a duplicate event.Additional manual checks:
200.401.401.404.Related Work