TSA-296: [BE] Update the lexicon when a page is verified - #339
Merged
yurii-tymoshevskyi merged 7 commits intoSep 24, 2026
Merged
Conversation
arturobdev
requested review from
IgnacioRB,
RomanNabukhotniidev,
anastasiia-matushenko,
anjoanka and
yurii-tymoshevskyi
September 19, 2026 02:25
arturobdev
added this pull request to stack #340
September 19, 2026 02:25
RomanNabukhotniidev
previously approved these changes
Sep 22, 2026
yurii-tymoshevskyi
previously approved these changes
Sep 22, 2026
arturobdev
dismissed stale reviews from yurii-tymoshevskyi and RomanNabukhotniidev
via
September 22, 2026 22:39
775391e
arturobdev
force-pushed
the
feat/TSA-296-update-lexicon-when-page-is-verified
branch
3 times, most recently
from
September 23, 2026 10:48
29663c6 to
73ebc54
Compare
arturobdev
force-pushed
the
feat/TSA-296-update-lexicon-when-page-is-verified
branch
3 times, most recently
from
September 23, 2026 14:06
52ddcdc to
6c2534d
Compare
arturobdev
requested review from
RomanNabukhotniidev and
yurii-tymoshevskyi
September 23, 2026 14:06
Yehor-Makarenko
removed this pull request from stack #340
September 23, 2026 15:11
RomanNabukhotniidev
previously approved these changes
Sep 23, 2026
Collaborator
|
god job! |
arturobdev
changed the base branch from
feat/TSA-140-sync-structured-output-with-corrected-text
to
main
September 23, 2026 22:24
arturobdev
dismissed
RomanNabukhotniidev’s stale review
September 23, 2026 22:24
The base branch was changed.
arturobdev
force-pushed
the
feat/TSA-296-update-lexicon-when-page-is-verified
branch
3 times, most recently
from
September 24, 2026 14:27
4a7d941 to
282bd83
Compare
arturobdev
force-pushed
the
feat/TSA-296-update-lexicon-when-page-is-verified
branch
from
September 24, 2026 14:50
282bd83 to
c02ff15
Compare
RomanNabukhotniidev
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #296
Summary
confirmandcorrect.skipdoes not contribute to the lexicon.lexiconAddedwith the entries affected by the verification.preset.settings.minDistinctPages.Testing
freqanddistinct_pages.minDistinctPages.correctaction does not change lexicon counters.lexiconAddedcontains the entries added or updated by the action.buildContext()includes learned lexicon entries in later-page context.Lexicon entries after verifying multiple pages:
lexiconAddedreturned by the verify endpoint:Learned lexicon entries included in later-page context: