forked from Drop-OSS/drop
-
Notifications
You must be signed in to change notification settings - Fork 1
chore: add SonarCloud sync script + CI integration #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f08d499
fix: batch remediation - resolve 12 open issues
d571994
fix: address code review feedback
4f52f3f
fix: address review feedback - SHA pinning, JWT fixes, cleanup
b08cdff
fix: resolve SonarCloud issues across codebase
2c71155
docs: add GitHub Issues & SonarCloud workflow to AGENTS.md
fa38fb2
fix: add permissions to scan-pr job for SARIF upload
7537ee2
fix: address code review findings
7a73cee
fix: reject empty page query string in news.tsx
7b3c90e
merge: resolve conflicts with develop
c3edbc2
fix: re-apply codeql build-mode none, fix missing i18n key
d2e7474
chore: add SonarCloud sync script + CI integration
337e552
Merge remote-tracking branch 'origin/develop' into fix/sonarcloud-issues
ff61937
chore: remove invalid auto_review key from CodeRabbit config
e0fe324
fix: address code review issues in SonarCloud sync
2dddeac
fix: address all code review findings
dd7ba51
fix: use correct nested i18n key for ageRatingValue
13e73c6
fix: revert CodeQL javascript-typescript build-mode to none
ffe30ab
fix: split Sonar job into scan and sync, guard sync on scan success
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,7 @@ jobs: | |
| -r | ||
| --skip-git | ||
| ./ | ||
| --format=sarif | ||
| --output=osv-scanner-results.sarif | ||
|
|
||
| - name: Upload SARIF | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: BillyOutlast/drop
Length of output: 2555
Don't let the Sonar scan be non-blocking on push
continue-on-error: truelets thesonarjob succeed even when the scan fails, sosonar-synccan run against stale or incomplete findings and update GitHub Issues incorrectly. Use the non-blocking behavior only for pull requests.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents