feat: Wave 1 - SonarCloud fixes, PR comment workflow, session filter

.github/workflows/ci.yml

@@ -210,6 +210,25 @@ jobs:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: bash scripts/sonarcloud-sync.sh
 
+  sonar-pr-comment:
+    name: SonarCloud PR Comment
+    runs-on: ubuntu-latest
+    needs: sonar
+    if: github.event_name == 'pull_request'
+    permissions:
+      contents: read
+      pull-requests: write
+    steps:
+      - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
+        with:
+          fetch-depth: 0
+      - name: Post SonarCloud findings to PR
+        env:
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GITHUB_PR_NUMBER: ${{ github.event.pull_request.number }}
+        run: bash scripts/sonarcloud-pr-comment.sh
+
   dockerfile:
     name: Dockerfile Lint
     runs-on: ubuntu-latest

.husky/pre-commit

@@ -3,6 +3,16 @@ fallow audit --format json --quiet --explain --gate-marker agent || exit 1
 
 pnpm --filter drop lint-staged && pnpm --filter drop typecheck
 
+# Check shell scripts
+changed_sh=$(git diff --cached --name-only --diff-filter=ACM -- '*.sh')
+if [ -n "$changed_sh" ]; then
+  if command -v shellcheck >/dev/null 2>&1; then
+    echo "$changed_sh" | xargs shellcheck --severity=warning || exit 1
+  else
+    echo "shellcheck not installed — skipping shell script checks"
+  fi
+fi
+
 # Check Rust formatting on changed .rs files, filtered by workspace
 changed_rs=$(git diff --cached --name-only --diff-filter=ACM -- '*.rs')
 if [ -n "$changed_rs" ]; then

Dockerfile

@@ -34,7 +34,7 @@
     && rm -rf /var/lib/apt/lists/*
 WORKDIR /build
 COPY . .
-RUN cargo build --release --manifest-path ./torrential/Cargo.toml
+RUN cargo build --locked --release --manifest-path ./torrential/Cargo.toml
 
 ### BUILD APP
 FROM base AS build-system
@@ -43,7 +43,7 @@
 ENV NUXT_TELEMETRY_DISABLED=1
 
 ## add git so drop can determine its git ref at build
 RUN apt-get update && apt-get install -y --no-install-recommends git \
     && rm -rf /var/lib/apt/lists/*
 
 ## copy deps and rest of project files

desktop/main/components/GameOptions/ProtonSelector.vue

@@ -1,24 +1,14 @@
 <template>
-  <Listbox
-    as="div"
-    v-model="model.overrideProtonPath"
-    class="mt-6"
-  >
-    <ListboxLabel class="block text-sm/6 font-medium text-white"
-      >Proton override</ListboxLabel
-    >
+  <Listbox as="div" v-model="model.overrideProtonPath" class="mt-6">
+    <ListboxLabel class="block text-sm/6 font-medium text-white">Proton override</ListboxLabel>
     <div class="relative mt-2">
       <ListboxButton
         class="grid w-full cursor-default grid-cols-1 rounded-md bg-white/5 py-1.5 pr-2 pl-3 text-left text-white outline-1 -outline-offset-1 outline-white/10 focus-visible:outline-2 focus-visible:-outline-offset-2 focus-visible:outline-blue-500 sm:text-sm/6"
       >
-        <span
-          v-if="currentProtonPath"
-          class="col-start-1 row-start-1 truncate pr-6"
+        <span v-if="currentProtonPath" class="col-start-1 row-start-1 truncate pr-6"
           >{{ currentProtonPath.name }} ({{ currentProtonPath.path }})</span
         >
-        <span
-          v-else
-          class="col-start-1 row-start-1 truncate pr-6 italic text-zinc-400"
+        <span v-else class="col-start-1 row-start-1 truncate pr-6 italic text-zinc-400"
           >No override configured</span
         >
         <ChevronUpDownIcon
@@ -35,22 +25,14 @@
         <ListboxOptions
           class="absolute z-10 mt-1 max-h-60 w-full overflow-auto rounded-md bg-zinc-800 py-1 text-base outline-1 -outline-offset-1 outline-white/10 sm:text-sm"
         >
-          <ListboxOption
-            as="template"
-            :value="undefined"
-            v-slot="{ active, selected }"
-          >
+          <ListboxOption as="template" :value="undefined" v-slot="{ active, selected }">
             <li
               :class="[
                 active ? 'bg-blue-500 text-white outline-hidden' : 'text-white',
                 'relative cursor-default py-2 pr-9 pl-3 select-none',
               ]"
             >
-              <span
-                :class="[
-                  selected ? 'font-semibold' : 'font-normal',
-                  'block truncate italic',
-                ]"
+              <span :class="[selected ? 'font-semibold' : 'font-normal', 'block truncate italic']"
                 >Use global default</span
               >
 
@@ -65,90 +47,106 @@
               </span>
             </li>
           </ListboxOption>
-          <h1 class="text-white text-sm font-semibold bg-zinc-900 py-2 px-2">
-            Auto-discovered
-          </h1>
+          <h1 class="text-white text-sm font-semibold bg-zinc-900 py-2 px-2">Auto-discovered</h1>
+          <template v-if="protonPaths.autodiscovered.length > 0">
+            <ListboxOption
+              as="template"
+              v-for="proton in protonPaths.autodiscovered"
+              :key="proton.path"
+              :value="proton.path"
+              v-slot="{ active, selected }"
+            >
+              <li
+                :class="[
+                  active ? 'bg-blue-500 text-white outline-hidden' : 'text-white',
+                  'relative cursor-default py-2 pr-9 pl-3 select-none',
+                ]"
+              >
+                <span :class="[selected ? 'font-semibold' : 'font-normal', 'block truncate']"
+                  >{{ proton.name }} ({{ proton.path }})</span
+                >
+
+                <span
+                  v-if="selected"
+                  :class="[
+                    active ? 'text-white' : 'text-blue-400',
+                    'absolute inset-y-0 right-0 flex items-center pr-4',
+                  ]"
+                >
+                  <CheckIcon class="size-5" aria-hidden="true" />
+                </span>
+              </li>
+            </ListboxOption>
+          </template>
           <ListboxOption
+            v-else
             as="template"
-            v-if="protonPaths.autodiscovered.length > 0"
-            v-for="proton in protonPaths.autodiscovered"
-            :key="proton.path"
-            :value="proton.path"
-            v-slot="{ active, selected }"
+            disabled
+            :value="null"
+            v-slot="{ active }"
           >
             <li
               :class="[
-                active ? 'bg-blue-500 text-white outline-hidden' : 'text-white',
-                'relative cursor-default py-2 pr-9 pl-3 select-none',
+                active ? 'bg-zinc-800' : '',
+                'italic text-zinc-400 py-2 pr-9 pl-3',
               ]"
             >
-              <span
+              No auto-discovered layers.
+            </li>
+          </ListboxOption>
+          <h1 class="text-white text-sm font-semibold bg-zinc-900 py-2 px-2">Manually added</h1>
+          <template v-if="protonPaths.custom.length > 0">
+            <ListboxOption
+              as="template"
+              v-for="proton in protonPaths.custom"
+              :key="proton.path"
+              :value="proton.path"
+              v-slot="{ active, selected }"
+            >
+              <li
                 :class="[
-                  selected ? 'font-semibold' : 'font-normal',
-                  'block truncate',
+                  active ? 'bg-blue-500 text-white outline-hidden' : 'text-white',
+                  'relative cursor-default py-2 pr-9 pl-3 select-none',
                 ]"
-                >{{ proton.name }} ({{ proton.path }})</span
               >
+                <span :class="[selected ? 'font-semibold' : 'font-normal', 'block truncate']"
+                  >{{ proton.name }} ({{ proton.path }})</span
+                >
 
-              <span
-                v-if="selected"
-                :class="[
-                  active ? 'text-white' : 'text-blue-400',
-                  'absolute inset-y-0 right-0 flex items-center pr-4',
-                ]"
-              >
-                <CheckIcon class="size-5" aria-hidden="true" />
-              </span>
-            </li>
-          </ListboxOption>
-          <li v-else class="italic text-zinc-400 py-2 pr-9 pl-3">
-            No auto-discovered layers.
-          </li>
-          <h1 class="text-white text-sm font-semibold bg-zinc-900 py-2 px-2">
-            Manually added
-          </h1>
+                <span
+                  v-if="selected"
+                  :class="[
+                    active ? 'text-white' : 'text-blue-400',
+                    'absolute inset-y-0 right-0 flex items-center pr-4',
+                  ]"
+                >
+                  <CheckIcon class="size-5" aria-hidden="true" />
+                </span>
+              </li>
+            </ListboxOption>
+          </template>
           <ListboxOption
+            v-else
             as="template"
-            v-if="protonPaths.custom.length > 0"
-            v-for="proton in protonPaths.custom"
-            :key="proton.path"
-            :value="proton.path"
-            v-slot="{ active, selected }"
+            disabled
+            :value="null"
+            v-slot="{ active }"
           >
             <li
               :class="[
-                active ? 'bg-blue-500 text-white outline-hidden' : 'text-white',
-                'relative cursor-default py-2 pr-9 pl-3 select-none',
+                active ? 'bg-zinc-800' : '',
+                'italic text-zinc-400 py-2 pr-9 pl-3',
               ]"
             >
-              <span
-                :class="[
-                  selected ? 'font-semibold' : 'font-normal',
-                  'block truncate',
-                ]"
-                >{{ proton.name }} ({{ proton.path }})</span
-              >
-
-              <span
-                v-if="selected"
-                :class="[
-                  active ? 'text-white' : 'text-blue-400',
-                  'absolute inset-y-0 right-0 flex items-center pr-4',
-                ]"
-              >
-                <CheckIcon class="size-5" aria-hidden="true" />
-              </span>
+              No manually added layers.
             </li>
           </ListboxOption>
-          <li v-else class="italic text-zinc-400 py-2 pr-9 pl-3">
-            No manually added layers.
-          </li>
         </ListboxOptions>
       </transition>
     </div>
     <p class="mt-2 text-sm text-zinc-400" id="launch-description">
-      Override the Proton layer used to launch this game. You can add or remove
-      your custom Proton layer paths in
+      Override the Proton layer used to launch this game. You can add or remove your custom Proton
+      layer paths in
       <PageWidget to="/settings/compat">
         <WrenchIcon class="size-3" />
         Settings </PageWidget
@@ -181,9 +179,7 @@ const protonPaths = await invoke<{
 }>("fetch_proton_paths");
 const currentProtonPath = computed(
   () =>
-    protonPaths.autodiscovered.find(
-      (v) => v.path == model.value.overrideProtonPath,
-    ) ??
+    protonPaths.autodiscovered.find((v) => v.path == model.value.overrideProtonPath) ??
     protonPaths.custom.find((v) => v.path == model.value.overrideProtonPath),
 );
 </script>

desktop/main/composables/current-page-engine.ts

@@ -14,7 +14,7 @@ export const useCurrentNavigationIndex = (
       .map((e, i) => ({ ...e, index: i }))
       .filter((e) => to.fullPath.startsWith(e.prefix));
     const bestOption = validOptions
-      .sort((a, b) => b.route.length - a.route.length)
+      .toSorted((a, b) => b.route.length - a.route.length)
       .at(0);
 
     return bestOption?.index ?? -1;

desktop/main/pages/settings/index.vue

@@ -1,16 +1,12 @@
 <template>
   <div class="border-b border-zinc-700 py-5">
-    <h3 class="text-base font-semibold font-display leading-6 text-zinc-100">
-      General
-    </h3>
+    <h3 class="text-base font-semibold font-display leading-6 text-zinc-100">General</h3>
   </div>
 
   <div class="mt-5 space-y-8">
     <div class="flex flex-row items-center justify-between">
       <div>
-        <h3 class="text-sm font-medium leading-6 text-zinc-100">
-          Start with system
-        </h3>
+        <h3 class="text-sm font-medium leading-6 text-zinc-100">Start with system</h3>
         <p class="mt-1 text-sm leading-6 text-zinc-400">
           Drop will automatically start when you log into your computer
         </p>
@@ -42,9 +38,12 @@ defineProps<{}>();
 const autostartEnabled = ref<boolean>(false);
 
 // Load initial state
-invoke("get_autostart_enabled").then((enabled) => {
-  autostartEnabled.value = enabled as boolean;
-});
+try {
+  const initialAutostart = await invoke<boolean>("get_autostart_enabled");
+  autostartEnabled.value = initialAutostart;
+} catch {
+  // Keep default false if IPC fails
+}
 
 // Watch for changes and update autostart
 watch(autostartEnabled, async (newValue: boolean) => {