Skip to content

Expose recall controls and harden OpenAI retry behavior.#46

Open
fricigliano wants to merge 4 commits intomasterfrom
improve_recall
Open

Expose recall controls and harden OpenAI retry behavior.#46
fricigliano wants to merge 4 commits intomasterfrom
improve_recall

Conversation

@fricigliano
Copy link
Copy Markdown
Contributor

@fricigliano fricigliano commented Mar 31, 2026 •
edited
Loading

  • Exposed sentiment_threshold and rerank_threshold in the brief-creation API and propagated them through validation plus exploratory/follow-up search calls — this enables callers to relax filtering thresholds on a per-request basis
  • Added explicit OpenAI client settings (timeout and max_retries) for both LLM and embedding clients
  • Added DEBUG diagnostics
  • Updated retry test assertions to use settings-driven retry counts

@fricigliano
Expose recall controls and harden OpenAI retry behavior.
3f9af83 
Add sentiment/rerank request controls across the brief pipeline, keep the initial probe rerank-free, and improve diagnosability with timing logs and timeout prompt dumps while aligning retry-related tests.

Made-with: Cursor
@fricigliano fricigliano requested a review from a team as a code owner March 31, 2026 11:56
@fricigliano
Fix ty type-check failures in CI.
34b850d 
Align WarningsMetrics.track_usage with Metrics parameter name, extend SentimentFilter for range-based API filters, build Result chunks as tuples, remove stale ty ignore, and cast json-repair output for strict typing.

Made-with: Cursor
@fricigliano
Fix remaining ty errors in API utils and metrics.
476ec7e 
Use safe cast for json_schema_extra example extraction and declare Metrics base class attributes so subclasses satisfy typed classmethod access.

Made-with: Cursor
@fricigliano
Fix import ordering in service module for CI lint.
6008ce0 
Apply Ruff import organization in service.py to satisfy lint-check import sorting rules.

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkakadiya-bigdata bkakadiya-bigdata Awaiting requested review from bkakadiya-bigdata

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fricigliano