fix: skip connects_to during eager load when SolidApm is disabled - #22
Merged
Merged
Conversation
… or unconfigured Agent-Logs-Url: https://github.com/Bhacaz/solid_apm/sessions/83963a43-6596-45e1-b436-bbccbe8152d0 Co-authored-by: Bhacaz <7858787+Bhacaz@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Bhacaz/solid_apm/sessions/83963a43-6596-45e1-b436-bbccbe8152d0 Co-authored-by: Bhacaz <7858787+Bhacaz@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Bhacaz
April 3, 2026 13:50
View session
Bhacaz
marked this pull request as ready for review
April 3, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
eager_load: true(e.g.CI=1), Zeitwerk loadsSolidApm::ApplicationRecordat boot time. The unconditionalconnects_tocall fails withActiveRecord::AdapterNotSpecifiedin environments (like test) that don't have asolid_apmdatabase configured — even though the Railtie correctly setsSolidApm.enabled = falsebefore initialization.Change
app/models/solid_apm/application_record.rb: Guardconnects_toso it only runs when SolidApm is enabled and a database connection is actually configured.No
database.ymlsolid_apmentry is required in test — consistent with the documented behavior that SolidApm is automatically disabled in the test environment.