Disable SolidAPM in test - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a configurable
enabledflag to SolidAPM, allowing the APM functionality to be disabled, with automatic disabling in the test environment to prevent test pollution and improve test performance. The changes ensure that SolidAPM's middleware and subscribers are only active when enabled, and provide documentation and tests for this behavior.Configuration and Environment Handling:
SolidApm.enabledconfiguration flag, defaulting totrue, and automatically set tofalsein the test environment via a newRailtie(lib/solid_apm.rb,lib/solid_apm/railtie.rb, [1] [2].README.mdto explain the newenabledflag and its default behavior in the test environment.Middleware and Subscriber Activation:
enabledflag, ensuring they are only active when SolidAPM is enabled (lib/solid_apm/engine.rb, [1] [2].lib/solid_apm/middleware.rb, lib/solid_apm/middleware.rbR10-R11).