feat(retrieval): Phase 6 — integration suite (real valkey-search)#245
Open
jamby77 wants to merge 1 commit into
Open
Conversation
98fc992 to
e1c6b81
Compare
a7ef1e0 to
94a8bf3
Compare
- Add Retriever.integration.test.ts (skip-guarded, VALKEY_URL default 6384) - Cover create index, upsert, vector query returning the upserted doc, TAG and NUMERIC filters, delete, health, and drop end-to-end - Add iovalkey devDependency for the integration client
e1c6b81 to
7d97a4d
Compare
94a8bf3 to
bd4a678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 6 — Integration suite (real Valkey + valkey-search)
Stacked on #243 (Phase 5) — base is the Phase 5 branch. Final phase of the Retrieval SDK.
What's new
Retriever.integration.test.ts— skip-guarded end-to-end suite against a real valkey-bundle (search module),VALKEY_URLdefaultredis://:devpassword@localhost:6384. Deterministic sha256fakeEmbed(8-dim).Covers the full SDK lifecycle:
createIndex(idempotent — called twice) →upsert→ vector query returns the upserted docid/text/fields/finitescore)register/unregisterdiscovery marker round-trip on__betterdb:cacheshealthsnapshot ·deleteremoves (polls for HNSW propagation) ·dropIndexcleans upReliability
HNSW indexing/deletion is asynchronous, so
beforeAllpolls until every doc is queryable and the delete test polls until propagation completes — no fixed sleeps, no order-dependence. Verified green and non-flaky across multiple live runs (9 integration tests; full package suite 101/101). Addediovalkeyas a devDependency (the library client is caller-supplied; iovalkey is only used by the test).Review-driven changes
A pre-PR review flagged indexing-lag races (filter/delete/hit-shape tests), a NaN-passes-
typeofscore check, and missing FT-capability skip-probe — all fixed; added precomputed-vector + register coverage.Note
Low Risk
Test-only changes and a devDependency; no production SDK behavior or runtime dependencies change.
Overview
Adds end-to-end integration tests for
Retrieveragainst a live Valkey instance with the search module (VALKEY_URL, defaultlocalhost:6384). Tests skip when Valkey orFT._LISTis unavailable.The suite exercises index create (idempotent), upsert, vector/text query, precomputed-vector query, TAG/NUMERIC filters, discovery register/unregister, health, delete, and
dropIndex.pollUntilwaits for async HNSW indexing and deletion instead of fixed sleeps.iovalkeyis added as a devDependency (tests only; the SDK still expects a caller-supplied client). Lockfile picks up the new package.Reviewed by Cursor Bugbot for commit bd4a678. Bugbot is set up for automated code reviews on this repo. Configure here.