AP-526: upgrade Rails and other dependencies #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omniauth-cas now requires a switch from a GET to POST, which leads us to need to modify how our login links exist and are styled (i.e., they are no longer truly links but rather forms). this thus updates css and modifies application helpers, too.
awilfox
reviewed
Dec 4, 2025
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Overall looking good. Mostly comments about the OmniAuth changes, and one minor DRY for CSS.
awilfox
approved these changes
Dec 4, 2025
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Looks great, just a missing ending newline in the scss file. r+ after that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the notable gap in this case isomniauth-cas, which needs some special magic...now with added omniauth-cas goodness!