fix(cli): prefer fresh iOS builds during onboarding#91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.appoutput inside an iOS checkout from being reused whennativeproof onboard /path/to/ios-reposhould build and stage a fresh simulator app.Proof
npm run checkpassed (biome check . && tsc --noEmit; checked 48 files).npm testpassed (184 tests, includingonboard builds an iOS project instead of reusing stale app outputand packed-package onboarding smoke).npm testincludespacked package exposes the onboarding CLI bins and ESM scaffold;npm pack --dry-run --jsonalso passed fornativeproof@0.13.0with 48 packed files. Device lane not applicable; no live Appium/device behavior changed.Risk
.app,.apk, and Android artifact onboarding still use existing detection.Notes
xcodebuildrunner and the package smoke remains green.PR Proof Law
.agents/DEFINITION_OF_DONE.mdand.agents/skills/pr-inline-screenshot-proof/SKILL.md., or the proof section saysNot applicablewith the technical reason.Screenshots: Not applicable — this is a CLI/onboarding routing fix with no rendered UI or screen state to capture. Behavioral proof is the committed regression test plus the full local command proof above.