chore(pr-quality): add proof-backed PR contract#8
Merged
Conversation
Fallow audit reportFound 1 finding. Details
Generated by fallow. |
Fallow audit report0 inline findings selected for GitHub review. |
🗺️ StyleProof report✓ No visual changes detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AgenticProjectTemplate already had strong gates and a Definition of Done, but PR readiness was not surfaced at PR creation time. This adds a review-facing contract so agents have to carry local proof, visual evidence status, CI status, and risk into the PR body instead of leaving reviewers to infer it.
What Changed
.agents/project/PR_QUALITY.mdas the tool-agnostic PR readiness contract..github/pull_request_template.mdso every PR starts with proof, CI status, risk, rollback, and Definition of Done prompts.pr-quality-contractskill under.claude/skills/.AGENTS.md,CLAUDE.md,.agents/README.md,.agents/project/DEFINITION_OF_DONE.md, andREADME.md.Proof
pnpm verifypnpm e2eN/Awith reason:N/A— docs, template, and skill-only change; no UI/CSS surface changed.N/Awith reason:N/A— StyleProof passed withNo visual changes.python3 /Users/agents/.codex/skills/.system/skill-creator/scripts/quick_validate.py .claude/skills/pr-quality-contract; pre-commit hook passed typecheck, staged Biome, Fallow, and gitleaks; pre-push hook passed coverage, build, and E2E.CI Status
Latest-sha checks are green: CI quality, Fallow, unit/component tests, production build, E2E behaviour map, security audit, CodeQL, Lighthouse, computed-style visual gate, and StyleProof.
Risk And Rollback
Low risk. This changes PR guidance, docs, and a repo-local skill; it does not change runtime code. Rollback is reverting the single commit if the contract is too strict or needs to be split differently.
Definition Of Done
N/A— no product behaviour changed.)N/A— no runtime logic changed.)N/A— no UI changed; existing Playwright axe scan passed.).agents/project/ARCHITECTURE.mdandCONVENTIONS.md.N/A— this codifies existing PR proof expectations, no new architecture choice.)