Skip to content

docs: require inline PR proof#15

Open
BenSheridanEdwards wants to merge 1 commit into
mainfrom
codex/pr-inline-proof-law
Open

docs: require inline PR proof#15
BenSheridanEdwards wants to merge 1 commit into
mainfrom
codex/pr-inline-proof-law

Conversation

@BenSheridanEdwards

Copy link
Copy Markdown
Owner

Why

Make inline screenshot proof part of the reusable agentic repo contract, not an optional agent habit.

What Changed

  • Added .agents/skills/pr-inline-screenshot-proof/SKILL.md.
  • Updated the Definition of Done, agent docs, Claude docs, and PR template with the inline proof law.

Proof

  • pnpm verify - not run, docs-only change.
  • pnpm e2e - not run, docs-only change.
  • Visual proof attached or linked, or N/A with reason: N/A - no rendered UI changed.
  • StyleProof reviewed, or N/A with reason: N/A - no rendered UI changed.
  • Other proof: git diff --check passed.

CI Status

  • Latest-sha GitHub Actions are green.
  • Pending checks are named below: checks may start after PR creation.
  • Failing checks are named below with the fix plan.

Risk And Rollback

Low risk docs/template change. Roll back by reverting this commit.

Definition Of Done

  • Behaviour is covered by the E2E map when user-visible behaviour changed - not applicable, docs-only change.
  • Logic is unit-tested where logic changed - not applicable.
  • Accessibility was considered and verified for interactive/UI changes - not applicable.
  • The diff follows .agents/project/ARCHITECTURE.md and CONVENTIONS.md.
  • Any new architectural decision is recorded as an ADR - not applicable.
  • No gates were bypassed or weakened.
  • Followed .agents/project/DEFINITION_OF_DONE.md and .agents/skills/pr-inline-screenshot-proof/SKILL.md.
  • Screenshots are committed and embedded inline with ![alt](...png?raw=1), or the proof section says Not applicable with the technical reason.
  • The PR body has no bare screenshot links, local paths, relative paths, or proof placeholders.

@github-actions

Copy link
Copy Markdown

Fallow audit report

Found 1 finding.

Details
Severity Rule Location Description
minor fallow/unused-dev-dependency package.json:44 Package '@lhci/cli' is in devDependencies but never imported

Generated by fallow.

@github-actions

Copy link
Copy Markdown

Fallow audit report

0 inline findings selected for GitHub review.

@github-actions

Copy link
Copy Markdown

🗺️ StyleProof report

✓ No visual changes detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant