Repository navigation
Open account-linking links in the host browser - #11
Merged
Merged
Conversation
2 tasks
TPV's Connect Garmin button (and Strava, TrainingPeaks, intervals.icu, etc.) calls OpenURL with an OAuth page whose redirect goes to api.indievelo.com, so no local callback is involved. Under Wine that reaches xdg-open, which had no browser in the container, so the click did nothing. The image's xdg-open now forwards http(s)/mailto links to the host through the OpenURI portal over the host session bus, which run-tpv.sh mounts. If the portal is unreachable it prints the link to open by hand. Refs #6
Refs #6 Co-Authored-By: Claude <noreply@anthropic.com>
BenA-SA
force-pushed
the
fix/garmin-open-links
branch
from
September 17, 2026 13:20
1224811 to
6a8bcd1
Compare
Owner
Author
|
Tested on top of master with #12 and #10 merged:
Note for the branch history: this branch was stacked on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking Connect Garmin when TPV loads did nothing (#6). The same applies to Strava, TrainingPeaks, intervals.icu and the other account-linking buttons. TPV opens an OAuth page through
xdg-open, and the container has no browser. The OAuth redirect goes toapi.indievelo.com, not a local callback, so all that's needed is to open the page in a browser.Changes
scripts/xdg-open-host.sh, installed as/usr/local/bin/xdg-open: forwardshttp(s)/mailtolinks to the host desktop throughorg.freedesktop.portal.OpenURIwithgdbus. If there's no session bus or the portal refuses, it prints the link to open by hand. Other link types are refused.Containerfile.full: addslibglib2.0-bin(gdbus) and the symlink.run-tpv.sh: mounts the host session bus ($XDG_RUNTIME_DIR/bus→/run/host-session-bus) and setsDBUS_SESSION_BUS_ADDRESS. It warns if there's no session bus.Testing
==> opened in host browser: https://...in the container output and the page in your browser. Then restart the container and check Garmin still shows as linked.Closes #6
🤖 Generated with Claude Code