Repository navigation
Fix main CI failures in lint, vulns, and Windows - #2
Merged
Merged
Conversation
The license check rejected smartware exec files that lacked the GPL header. govulncheck reached fzf before v0.73.1 and oras-go/v2 v2.6.1 through the OCI registry client. The Windows GUI build pinned tcell v3.6.5 and ebiten v2.7.5-ub.27, which predate the merged console and InitHint fixes, and CGO was off so tree-sitter could not compile. Bump those modules, build Windows with MinGW, and patch rune-go-sdk v0.2.0 in the Windows job because no published release compiles there. Co-authored-by: No Namegiven <dallasbell1982@gmail.com>
CurrentUserHostURI and the local file scheme built file://D:\... which url.Parse treats as a host plus an invalid port. Drive paths now use an empty host, and the Windows job applies that SDK fix before the smoke test. Co-authored-by: No Namegiven <dallasbell1982@gmail.com>
file:///D:/a/rune parses to the path /D:/a/rune, which CreateFile rejects as \D:\a\rune. Drop that extra slash so the stored path is an OS path the file scheme can open. Co-authored-by: No Namegiven <dallasbell1982@gmail.com>
The test suite passed. codecov-action still exited 1 on an SSL handshake failure even with fail_ci_if_error set to false, which failed the Linux workflow. Keep that upload from failing the job. Co-authored-by: No Namegiven <dallasbell1982@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
3692aa58failed Lint, Security, and Windows. Linux and macOS were already green. This branch fixes the three failures without disabling or weakening a test check.Lint: missing GPL headers
Check GPL-3.0 headersrequiresCopyright (C) <year> The Rune Authorsin the first three lines.internal/smartware/exec.goandinternal/smartware/exec_test.gowere the only files missing it. They now use the same header as the rest of the tree.Security: govulncheck
govulncheck ./...reported three reachable vulnerabilities in two modules:github.com/junegunn/fzfv0.0.0-20201216124428-ab3937ee5a62v0.73.1oras.land/oras-go/v2v2.6.1v2.6.2oras.land/oras-go/v2v2.6.1v2.6.2The oras findings are reached from
internal/llm/llamacpp/ociregistry/client.go(remote,retry,auth). The fzf finding is the whole module; search callsalgo.FuzzyMatchV2/EqualMatch. Both modules are bumped to the fixed versions.fzf v0.73.1 no longer fills its ASCII class table in
init. Case-insensitive fuzzy match was returning no hits for capitals untilalgo.Init("default"). That call is ininternal/handler/search, with a regression test.govulncheckdoes not run on pull requests (the Security workflow skips it unless the event is a push or the weekly cron). A local run after these bumps reports 0 vulnerabilities reached by this code. One imported-package advisory and four required-module advisories remain, and govulncheck says this code does not call them, which is the same class of result the check already ignores.Windows
The Windows job compiles
./cmd/runewith-tags=ebitensinglethread, then runsrune.exe --versionand the graphics package tests.Fork pins
The first compile died in two forks the windows-graphics merge did not pin:
github.com/unstablebuild/tcell/v3@v3.6.5console_win.go:*cScreenis missingBell,CellBuffer.Invalidate,evch, andNewEventKeywants a fourth argument. Those methods landed in unstablebuild/tcell#6 (90d3af1, three commits afterv3.6.5, untagged). Pinned tov3.6.6-0.20260919122710-90d3af1d7f12.github.com/unstablebuild/ebiten/v2@v2.7.5-ub.27ui_glfw.go:glfw.InitHintis undefined on Windows. The stub is unstablebuild/ebiten#1 (6f1d591, one commit afterv2.7.5-ub.32, untagged). The replace is nowv2.7.6-0.20260916232601-6f1d59169775.CGO and Unix-only APIs
With those pins,
CGO_ENABLED=0still cannot build the binary: tree-sitter is cgo (undefined: tree_sitter.Parser). Ebiten itself does not need cgo underebitensinglethread, but the rest ofcmd/runedoes. The Windows job installs MinGW gcc and builds withCGO_ENABLED=1.The same build then hit Unix-only
syscallfields (Setpgid,Setsid,Setctty,SIGUSR1/SIGUSR2,SIGURG,syscall.Kill,Socketpair,unix.Dup2). Those call sites now have Unix and Windows files. Unix behavior is unchanged. On Windows, process-group and session attributes are empty, LSP socketpair returns a clear error, and stderr redirection usesSetStdHandle.SDK patch (no published fix)
github.com/unstablebuild/rune-go-sdk@v0.2.0has two Windows breaks, and neitherv0.2.1normainfixes them:workspacerpc/client.goreadsSysProcAttr.SetsidandSetctty, which do not exist on Windows. The patch reads them with reflection, so Unix still forwards the flags and Windows keeps them false.CurrentUserHostURIbuildsfile://+ the raw path.D:\a\rune\runebecomes a URL whose drive letter is a host and whose rest is an invalid port, sorune.exe --versionfataled before printing. The patch forces an empty host, then drops the extra slash so the stored path is an OS path (D:\a\rune\rune) instead of\D:\a\rune\rune, whichCreateFilerejects. The in-repo file-scheme helper does the same, covered byTestMakeLocalURI.The Windows job applies
scripts/rune-go-sdk-windows.patchto the module cache before compiling. A proper fix is those two changes upstream; this repo cannot publish that module.Linux codecov upload
On the previous commit the Linux Test step passed. The following
codecov-actionstep exited 1 onEPROTO/ TLS handshake failure to the upload host, even thoughfail_ci_if_erroris alreadyfalse. That upload is not the test gate, so the step iscontinue-on-error. The race-detector test run is unchanged.Verification
govulncheck ./...exits 0 (0 reached vulnerabilities).rune.exe --version, wingfx, font tests) is green on this branch.internal/handler/search,internal/smartware,internal/llm/llamacpp/ociregistry,internal/workspace(includingTestStartCommandandTestMakeLocalURI),internal/workspace/workspacerpc,internal/workspace/workspacessh,internal/extension/extensionv2process-group test,internal/ide/idelsp,internal/ide/idedebug,internal/term/vte,cmd/rune.