Skip to content

Fix main CI failures in lint, vulns, and Windows - #2

Merged
Bell8571 merged 4 commits into
mainfrom
cursor/fix-main-ci-8752
Oct 5, 2026
Merged

Bell8571 merged 4 commits into
mainfrom
cursor/fix-main-ci-8752

Conversation

@Bell8571

@Bell8571 Bell8571 commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

Summary

CI on 3692aa58 failed Lint, Security, and Windows. Linux and macOS were already green. This branch fixes the three failures without disabling or weakening a test check.

Lint: missing GPL headers

Check GPL-3.0 headers requires Copyright (C) <year> The Rune Authors in the first three lines. internal/smartware/exec.go and internal/smartware/exec_test.go were the only files missing it. They now use the same header as the rest of the tree.

Security: govulncheck

govulncheck ./... reported three reachable vulnerabilities in two modules:

ID Module Found Fixed
GO-2026-6620 github.com/junegunn/fzf v0.0.0-20201216124428-ab3937ee5a62 v0.73.1
GO-2026-6499 oras.land/oras-go/v2 v2.6.1 v2.6.2
GO-2026-6497 oras.land/oras-go/v2 v2.6.1 v2.6.2

The oras findings are reached from internal/llm/llamacpp/ociregistry/client.go (remote, retry, auth). The fzf finding is the whole module; search calls algo.FuzzyMatchV2 / EqualMatch. Both modules are bumped to the fixed versions.

fzf v0.73.1 no longer fills its ASCII class table in init. Case-insensitive fuzzy match was returning no hits for capitals until algo.Init("default"). That call is in internal/handler/search, with a regression test.

govulncheck does not run on pull requests (the Security workflow skips it unless the event is a push or the weekly cron). A local run after these bumps reports 0 vulnerabilities reached by this code. One imported-package advisory and four required-module advisories remain, and govulncheck says this code does not call them, which is the same class of result the check already ignores.

Windows

The Windows job compiles ./cmd/rune with -tags=ebitensinglethread, then runs rune.exe --version and the graphics package tests.

Fork pins

The first compile died in two forks the windows-graphics merge did not pin:

  • github.com/unstablebuild/tcell/v3@v3.6.5 console_win.go: *cScreen is missing Bell, CellBuffer.Invalidate, evch, and NewEventKey wants a fourth argument. Those methods landed in unstablebuild/tcell#6 (90d3af1, three commits after v3.6.5, untagged). Pinned to v3.6.6-0.20260919122710-90d3af1d7f12.
  • github.com/unstablebuild/ebiten/v2@v2.7.5-ub.27 ui_glfw.go: glfw.InitHint is undefined on Windows. The stub is unstablebuild/ebiten#1 (6f1d591, one commit after v2.7.5-ub.32, untagged). The replace is now v2.7.6-0.20260916232601-6f1d59169775.

CGO and Unix-only APIs

With those pins, CGO_ENABLED=0 still cannot build the binary: tree-sitter is cgo (undefined: tree_sitter.Parser). Ebiten itself does not need cgo under ebitensinglethread, but the rest of cmd/rune does. The Windows job installs MinGW gcc and builds with CGO_ENABLED=1.

The same build then hit Unix-only syscall fields (Setpgid, Setsid, Setctty, SIGUSR1/SIGUSR2, SIGURG, syscall.Kill, Socketpair, unix.Dup2). Those call sites now have Unix and Windows files. Unix behavior is unchanged. On Windows, process-group and session attributes are empty, LSP socketpair returns a clear error, and stderr redirection uses SetStdHandle.

SDK patch (no published fix)

github.com/unstablebuild/rune-go-sdk@v0.2.0 has two Windows breaks, and neither v0.2.1 nor main fixes them:

  1. workspacerpc/client.go reads SysProcAttr.Setsid and Setctty, which do not exist on Windows. The patch reads them with reflection, so Unix still forwards the flags and Windows keeps them false.
  2. CurrentUserHostURI builds file:// + the raw path. D:\a\rune\rune becomes a URL whose drive letter is a host and whose rest is an invalid port, so rune.exe --version fataled before printing. The patch forces an empty host, then drops the extra slash so the stored path is an OS path (D:\a\rune\rune) instead of \D:\a\rune\rune, which CreateFile rejects. The in-repo file-scheme helper does the same, covered by TestMakeLocalURI.

The Windows job applies scripts/rune-go-sdk-windows.patch to the module cache before compiling. A proper fix is those two changes upstream; this repo cannot publish that module.

Linux codecov upload

On the previous commit the Linux Test step passed. The following codecov-action step exited 1 on EPROTO / TLS handshake failure to the upload host, even though fail_ci_if_error is already false. That upload is not the test gate, so the step is continue-on-error. The race-detector test run is unchanged.

Verification

  • License-header scan matches the Lint job and reports no missing headers.
  • govulncheck ./... exits 0 (0 reached vulnerabilities).
  • Windows cross-compile with MinGW, and the Windows workflow (rune.exe --version, wingfx, font tests) is green on this branch.
  • macOS workflow is green.
  • Package tests: internal/handler/search, internal/smartware, internal/llm/llamacpp/ociregistry, internal/workspace (including TestStartCommand and TestMakeLocalURI), internal/workspace/workspacerpc, internal/workspace/workspacessh, internal/extension/extensionv2 process-group test, internal/ide/idelsp, internal/ide/idedebug, internal/term/vte, cmd/rune.
Open in Web Open in Cursor 

cursoragent and others added 4 commits October 5, 2026 00:42
The license check rejected smartware exec files that lacked the GPL
header. govulncheck reached fzf before v0.73.1 and oras-go/v2 v2.6.1
through the OCI registry client. The Windows GUI build pinned tcell
v3.6.5 and ebiten v2.7.5-ub.27, which predate the merged console and
InitHint fixes, and CGO was off so tree-sitter could not compile.

Bump those modules, build Windows with MinGW, and patch rune-go-sdk
v0.2.0 in the Windows job because no published release compiles there.

Co-authored-by: No Namegiven <dallasbell1982@gmail.com>
CurrentUserHostURI and the local file scheme built file://D:\... which
url.Parse treats as a host plus an invalid port. Drive paths now use an
empty host, and the Windows job applies that SDK fix before the smoke
test.

Co-authored-by: No Namegiven <dallasbell1982@gmail.com>
file:///D:/a/rune parses to the path /D:/a/rune, which CreateFile
rejects as \D:\a\rune. Drop that extra slash so the stored path is an
OS path the file scheme can open.

Co-authored-by: No Namegiven <dallasbell1982@gmail.com>
The test suite passed. codecov-action still exited 1 on an SSL
handshake failure even with fail_ci_if_error set to false, which failed
the Linux workflow. Keep that upload from failing the job.

Co-authored-by: No Namegiven <dallasbell1982@gmail.com>
@Bell8571
Bell8571 merged commit d2327fc into main Oct 5, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants