[ci] disable cpplint header-guard check after repo rename to ExaBoost#11
Merged
Conversation
cpplint's --root=.. workaround derived the expected header-guard prefix from the parent directory name. After renaming the repo to ExaBoost, that prefix changed from LIGHTGBM_INCLUDE_*_H_ to EXABOOST_INCLUDE_*_H_ and every header now fails build/header_guard. We deliberately did not rename the C/C++ symbols (still LightGBM, LGBM_*, import lightgbm) to keep ExaBoost binary-compatible. Disable the header-guard check in the cpplint pre-commit hook to match the existing setup in .ci/lint-cpp.sh. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cpplint's pre-commit hook uses
--root=..to derive the expected header-guard prefix from the parent directory name. Before the rename that gaveLIGHTGBM_INCLUDE_LIGHTGBM_*_H_; after rename to ExaBoost it expectsEXABOOST_INCLUDE_LIGHTGBM_*_H_, so every header now failsbuild/header_guard.We deliberately did not rename the C/C++ symbols — ExaBoost is binary-compatible with LightGBM (
#include <LightGBM/...>,LGBM_*API,import lightgbm). The header guards correctly sayLIGHTGBM_*. The lint expectation is what's wrong, not the headers.Fix
Drop
--root=..and add-build/header_guardto the cpplint filter list, matching what.ci/lint-cpp.shalready does. No code changes; pre-commit config only.Effect
Resolves the cpplint failure that's currently blocking every PR's Static Analysis check (PRs #4, #6–#10 all hit it).
🤖 Generated with Claude Code