Skip to content

Fix thread memory startup and add a user memory guide - #370

Open
vinayagg wants to merge 1 commit into
mainfrom
codex/memory-help-and-thread-fix
Open

vinayagg wants to merge 1 commit into
mainfrom
codex/memory-help-and-thread-fix

Conversation

@vinayagg

@vinayagg vinayagg commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

What broke

Every Goal and Chat failed at startup with “Shared knowledge belongs to teams,” in both local and regular organizations. Users also lacked an in-app explanation of memory scopes and how to test them.

Why

Recalled execution context was attached to thread.knowledge, a field reserved for persisted team records. The real runner validates the execution thread while preparing its workspace, so even an empty recall triggered the team-only guard.

What changed

  • Pass recalled knowledge as a separate execution argument, preserving the team-only storage validation.
  • Add a regression test through the real runner's workspace preflight, covering Goals and Chat in local and regular organizations with both empty and populated recall. Preserve private-preference isolation.
  • Add a simple HTML memory guide explaining threads, teams, organizations, private preferences, sharing, and offline behavior. Include step-by-step instructions and copyable prompts for recall, corrections, and forgetting.
  • Link the guide from Help → How memory works in desktop and web clients. Serve the same fixed, script-free documentation page without account data or workspace provisioning, and package it with the desktop plugin.

Tested

  • Reproduced the startup failure in the new regression test before applying the fix; it passes after the fix.
  • 70 help, navigation, update, and knowledge tests pass.
  • TypeScript checking, desktop build, hosted UI build, plugin staging, packaged-guide loading, and git diff --check pass.
  • Live browser visual preview was blocked by browser URL policy. Existing full-suite local-socket restrictions remain; no claim of full end-to-end model or two-desktop validation.

Not touched

No server API or Rust changes. Existing memory scopes, sharing permissions, and team-only persisted knowledge validation remain enforced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant