Repository navigation
Isolate thread sharing failures from other work - #361
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
An incomplete organization setup or a failed thread registration or metadata update could prevent unrelated saved conversations from loading. Some unrelated permission errors were also shown as revoked thread access.
Why
Refreshing the directory attempted to sync every locally owned thread and stopped at the first failure. Reads depended on that refresh, so one document's failure affected other work.
What changed
Tested
npm run checkpassed on the final branch, including client regressions, TypeScript checks, and desktop and hosted UI builds. Native installer packaging and manual UI testing were not run.