Repository navigation
fix the shared folder check's raw errors and two minute wait - #359
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the file sync paths turned up two problems in the shared folder screen.
Picking a folder before Google Drive has synced its
.bees-shared.jsonmarker, or typing a path that doesn't exist, showed the raw system error with the full path ("ENOENT: no such file or directory, lstat ..."). Now it says the folder has no Bees marker yet, or asks for an existing folder. The folder list still shows it as missing.Check synchronization against a client that's offline sat on "Checking..." for two minutes and then failed with "Peer connection timed out". It waited out the relay's own timeout twice, once for the check and once for the cleanup message. Now it stops at its own 15 second limit and says synchronization isn't confirmed, which is what the help page describes.