fixed teamtalk crash when you opened context menu on empty server list#3365
Open
amirmahdifard wants to merge 1 commit into
Open
fixed teamtalk crash when you opened context menu on empty server list#3365amirmahdifard wants to merge 1 commit into
amirmahdifard wants to merge 1 commit into
Conversation
amirmahdifard
force-pushed
the
serverlistCrashfix
branch
2 times, most recently
from
July 13, 2026 23:18
2973cfb to
b2b30fa
Compare
amirmahdifard
force-pushed
the
serverlistCrashfix
branch
from
July 18, 2026 21:00
cd8ebf0 to
5220dac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the server list is completely empty and you have no selection and you open the context menu on it, causes crash. This is because in 5.23, someone incorrectly handled this that the code would grab the nul.
But in 5.22 and older, the validations were correctly seperated, so the code didn't crash, And we would stil have the possible options.
protected the crash cause behind safe gard, like the same stile as the other views.
No Crash: If the list is empty, the && stops the code from looking for [srcIndex.row()].