Fix navigation logic for physical phone's back button#3358
Fix navigation logic for physical phone's back button#3358amirmahdifard wants to merge 1 commit into
Conversation
|
@bear101 Finally, I did my best to wright clean and explaning commit messages, clean comments, with no spelling mistakes😊 |
|
I only have the emulator to test Android. When i press Back button then it still returns immediately to the server list. |
|
@bear101 what's your android version? may be I need to use the onBackPressed dispachor anyway instead of the discontinued onBackPressed method. |
|
I will push a new commit, please tell me if that fixes it or not. |
|
@bear101 would you please try it one more time? |
|
@bear101 please when you tested this again, also tell me is the shrinking exit animation for android works fine with this? because I also want to handle android's shrinking exit animation |
|
@bear101 bro, remember in 2024 you promiced me that you will give me a teamtalk sdk lisence soon? |
|
Well, now we all know exactly why you’re so eager to get your contributions merged into the project 🤣 |
|
@Nardol no today my friend asked me to run a pro server, and it's not possible to run it without lisence. One of my friends gave me a tt sdk lisence But i don't like to use it. And it's not linked to my account anyway. Also, it's not so much important, I just remembered and asked. |
1ff97f4 to
9492af8
Compare
Previously, users could only navigate TeamTalk safely using the "Navigate Up" button. The phone's physical back button was not supported, causing users to be disconnected immediately and lose their session. This change handles the phone's back button to act the same as the navigation button. Refactored the code into a clean helper method for both to use, with clear comments indicating each step of the logic.