Skip to content

Remove debug branch logic and add paths filter to workflows#3195

Open
hwangsihu wants to merge 2 commits into
masterfrom
gh-no-debug
Open

Remove debug branch logic and add paths filter to workflows#3195
hwangsihu wants to merge 2 commits into
masterfrom
gh-no-debug

Conversation

@hwangsihu

Copy link
Copy Markdown
Contributor

No description provided.

@bear101 bear101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems incredibly complicated as compared to checking the branch name prefix.

@hwangsihu
hwangsihu force-pushed the gh-no-debug branch 2 times, most recently from 438cbd7 to 24b0741 Compare April 22, 2026 12:51
@hwangsihu
hwangsihu force-pushed the gh-no-debug branch 2 times, most recently from 9c5d68b to 1d51455 Compare May 4, 2026 10:58
@hwangsihu

Copy link
Copy Markdown
Contributor Author

Doing it this way is beneficial when receiving PRs from external users. Currently, many PRs have been submitted to modify the Android client, but unnecessary CI processes are starting alongside them, causing delays and resulting in numerous error emails.

@bear101

bear101 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

I think this PR adds unnecessary complexity to the workflows.

@hwangsihu

Copy link
Copy Markdown
Contributor Author

I think this PR adds unnecessary complexity to the workflows.

Isn't it inconvenient to keep receiving failure emails regarding unnecessary workflows in PRs?

Also, this is a method adopted by other repositories. If you look at the CI code of large-scale projects, most of them do it this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants