Repository navigation
fix(electron): register missing getGitHubStars IPC handler and guard window teardown - #91
Merged
ExtraBinoss merged 3 commits intoOct 4, 2026
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses runtime uncaught IPC exceptions during UI initialization, prevents race conditions during window teardown, and fixes a Node 22+ test assertion failure.
Problem
getGitHubStarsviaipcRenderer.invoke(), but no matching handler was registered inelectron/main.cjs.electron/lifecycle/fatal-events.cjs, accessingBrowserWindowinstances during fatal error handling throws an exception if the window has already been destroyed.test/screenshot-images.test.cjs, runningfs.rmSyncon a symlinked directory fails withEISDIRon Node 22+.Solution
ipcMain.handle('community:get-github-stars')inelectron/main.cjs.electron/lifecycle/fatal-events.cjsto ignore benignObject has been destroyedrejections during teardown.server.strictPort: trueinvite.config.ts.{ recursive: true }tofs.rmSyncwhen removing the symlinked directory intest/screenshot-images.test.cjs.Verification
bun run typecheck(0 errors)bun run test(770/770 passed)