Fix server crash when mods.json is empty #455
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiserTixx
requested changes
Dec 27, 2025
src/TResourceManager.cpp
Outdated
|
|
||
| if (std::filesystem::exists(Path + "/mods.json")) { | ||
| auto modsJsonPath = Path + "/mods.json"; | ||
| if (std::filesystem::exists(modsJsonPath) && std::filesystem::file_size(modsJsonPath) > 0) { |
Collaborator
There was a problem hiding this comment.
Could a beammp_warn log be made when the file is empty? That way there's at least a trace of something not going as intended. Something along the lines of "Mods json database is empty, ignoring it"
src/TResourceManager.cpp
Outdated
| auto modsDBPath = Application::Settings.getAsString(Settings::Key::General_ResourceFolder) + "/Client/mods.json"; | ||
|
|
||
| if (std::filesystem::exists(modsDBPath)) { | ||
| if (std::filesystem::exists(modsDBPath) && std::filesystem::file_size(modsDBPath) > 0) { |
Collaborator
There was a problem hiding this comment.
Could there be some kind of attempt to regenerate the file here? This way the protect command just gets completely disregarded with no info.
Collaborator
|
Yes, this would technically solve the issue linked. However I'd like to figure out why that happened in the first place before closing it. |
Check file size before attempting to parse mods.json. Empty files are now gracefully ignored instead of causing a parse error. Closes BeamMP#442
Kipstz
force-pushed
the
fix-empty-mods-json
branch
from
b9cce23 to
96c7491
Compare
WiserTixx
requested changes
Jan 10, 2026
| inStream >> modsDB; | ||
| inStream.close(); | ||
| } else { | ||
| beammp_warn("Mods database file is empty, regenerating it"); |
Collaborator
There was a problem hiding this comment.
I might be overlooking something here, but is the regeneration code missing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check file size before attempting to parse mods.json.
Empty files are now gracefully ignored instead of causing a parse error.