fix(address-search): keep autocomplete cache through re-selection

[divazbozz]

Summary

this is a refactor to clean up a old buggy behavior

• resolveSelection used to clear cache, placesRef, and token at the end of every resolve, so re-selecting the same suggestion returned undefined.
• Callers (BatteryAddressSearchFlow, EnergyOnlyAddressEntryFlow) worked around this with a lastConfirmDataRef fallback that leaked the hook's caching internals into every caller.
• Drop the eager reset so the cache lives for the hook's lifetime, and remove the lastConfirmDataRef workaround from both flows.

Test plan

see my test step below

• Open http://localhost:5173/ (top dark "Street address" input).
• Type 2500 Longview St, pick "2500 Longview St, Conroe, TX, USA" from the dropdown.
• The "Confirm your address" modal should appear.
• Click Close.
• Click in the input → dropdown reopens with the same suggestion.
• Click the same suggestion again.
• Expected with the fix: the "Confirm your address" modal reopens (because resolveSelection still returns the place, the flow hits onRequiresAddressConfirm).
• Old buggy behavior: nothing would happen on the second click (resolveSelection returned undefined → old code fell through to lastConfirmDataRef fallback; without that fallback the flow would silently do nothing).

Screen.Recording.2026-04-20.at.4.37.45.PM.mov

🤖 Generated with Claude Code

---

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include rabbit in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 49450b8c-0659-4811-94cf-02268a74b850

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/zen-kilby-964540

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[devin-ai-integration]

Devin Review found 1 potential issue.

View 3 additional findings in Devin Review.

[devin-ai-integration]

🟡 Google Places session token never reset after selection completes a session

The PR removes token.current = null from resolveSelection, which previously reset the session token after fetchFields() completed a Google Places autocomplete session. Google's Places API uses the session token to group autocomplete requests and the final place-details fetch into a single billing session. Once fetchFields() is called, that session is consumed. In the new code, the same consumed token is reused for all subsequent fetchAutocompleteSuggestions calls (useAddressAutocomplete.ts:62), meaning every autocomplete request after the first selection may be billed individually rather than at session pricing.

The DESIGN.md (src/address-search/DESIGN.md:98) explicitly states this hook should "manage the Google Places session token lifecycle," and the surviving comment at useAddressAutocomplete.ts:43-44 describes a per-session intent. The fix should restore token.current = null (to start a new session on the next search) while keeping the cache and placesRef intact to preserve the PR's goal of avoiding the lastConfirmDataRef fallback.

---

Was this helpful? React with 👍 or 👎 to provide feedback.