Skip to content

[address] modal confirm address#38

Merged
divazbozz merged 8 commits intomainfrom
dz/modal-confirm-address
Apr 1, 2026
Merged

[address] modal confirm address#38
divazbozz merged 8 commits intomainfrom
dz/modal-confirm-address

Conversation

@divazbozz
Copy link
Copy Markdown
Contributor

@divazbozz divazbozz commented Apr 1, 2026 •
edited
Loading

Implementation

  • update our subpremise validation to a modal for better experience
  • remove the existing "add apartment number" toggle
  • remove code related to address component from energyonly component

Test

Screen.Recording.2026-04-01.at.3.04.17.PM.mov
Open with Devin

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 1, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include rabbit in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9932e1f8-73cc-4df6-a767-752192ba9801

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dz/modal-confirm-address

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@divazbozz divazbozz force-pushed the dz/modal-confirm-address branch from ada9fb2 to f903eee Compare April 1, 2026 18:38
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

lukejosephy
lukejosephy reviewed Apr 1, 2026
View reviewed changes
Comment thread src/address-search/modal/AddressConfirmModal.tsx Outdated
import { cx } from "@/utils/cx";
import styles from "./styles.module.css";

function CloseIcon() {
Copy link
Copy Markdown

@lukejosephy lukejosephy Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to it's own icon component file

Comment thread biome.json
"files": {
"ignoreUnknown": true,
"includes": ["**", "!dist"]
"includes": ["**", "!dist", "!.claude"]
Copy link
Copy Markdown

@lukejosephy lukejosephy Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this

Copy link
Copy Markdown
Contributor Author

@divazbozz divazbozz Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore from biome lint, this is local .claude for folks

@divazbozz divazbozz merged commit 2233848 into main Apr 1, 2026
2 checks passed
@divazbozz divazbozz deleted the dz/modal-confirm-address branch April 1, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@lukejosephy lukejosephy lukejosephy approved these changes

@jpreillymb jpreillymb Awaiting requested review from jpreillymb

@jbaskin125 jbaskin125 Awaiting requested review from jbaskin125

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@divazbozz @lukejosephy