Skip to content

SWI-8574 Add wait to StopStream Verb #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckoegel merged 1 commit into from
Sep 5, 2025
Merged

SWI-8574 Add wait to StopStream Verb #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions models/bxml/verbs/StopStream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { Verb } from '../Verb';

export interface StopStreamAttributes {
name: string;
wait?: boolean;
}

/**
Expand Down
3 changes: 2 additions & 1 deletion tests/smoke/bxml.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,8 @@ describe('BXML Integration Tests', () => {
};

const stopStreamAttributes: StopStreamAttributes = {
name: 'initialName'
name: 'initialName',
wait: true
};

const stopTranscriptionAttributes: StopTranscriptionAttributes = {
Expand Down
5 changes: 3 additions & 2 deletions tests/unit/models/bxml/verbs/StopStream.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ import { StopStream, StopStreamAttributes } from '../../../../../models/bxml/ver

describe('StopStream', () => {
const attributes: StopStreamAttributes = {
name: 'initialName'
name: 'initialName',
wait: true
};

const expected = '<StopStream name="initialName"/>';
const expected = '<StopStream name="initialName" wait="true"/>';

test('should create a StopStream Verb', () => {
const stopStream = new StopStream(attributes);
Expand Down