Fix X11 NULL-deref, leaks, and unbounded copies - #615
Open
EzeriumChristinal wants to merge 5 commits into
Open
EzeriumChristinal wants to merge 5 commits into
EzeriumChristinal wants to merge 5 commits into
Conversation
added 5 commits
September 6, 2026 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a stack with "Stop closing the shared session-bus connection per focus event" — merge in that order.
x11GetFocusWindowClass crashed with no X display (pure Wayland) and leaked its returned string on every FocusIn; the Go wrapper frees it now. Property walks leaked skipped FocusProxy strings and XQueryTree children. Copies into the 100-byte clipboard/watcher buffers are bounded, and NULL names and displays return early.
C changes only; verified with a full cgo + GTK UI build and the Go test suite.