Skip to content

Load lookup data without racing or crashing; finish engine setup in the constructor #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EzeriumChristinal wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Load lookup data without racing or crashing; finish engine setup in the constructor #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb036d9
Settle composition state on focus change, reset, disable
Sep 6, 2026
4f8e70a
Give each engine its own key queue; serialize engine state
Sep 6, 2026
7b31c77
Load lookup data without racing or crashing; harden startup paths
Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions emoji.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,14 @@ func NewEmojiEngine() *EmojiEngine {
}

func (be *EmojiEngine) MatchString(s string) bool {
var lookup = FindPrefix(emojiTrie, s)
var lookup = FindPrefix(currentEmojiTrie(), s)
return lookup != nil
}

func (be *EmojiEngine) Filter(s string) []string {
var codePoints []string
var keys []string
var lookup = FindPrefix(emojiTrie, s)
var lookup = FindPrefix(currentEmojiTrie(), s)
for key := range lookup {
keys = append(keys, key)
}
Expand Down
8 changes: 6 additions & 2 deletions emoji_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ import (
)

func TestEmojiFindResult(t *testing.T) {
emojiTrie, _ = loadEmojiOne(DictEmojiOne)
if trie, err := loadEmojiOne(DictEmojiOne); err == nil {
emojiTrie.Store(trie)
}
var be = NewEmojiEngine()
if be.MatchString(":'") != true {
t.Errorf("Finding result for emoji :', expected true, got %v", be.MatchString(":'"))
Expand All @@ -40,7 +42,9 @@ func TestEmojiFindResult(t *testing.T) {
}

func TestFilterEmoji(t *testing.T) {
emojiTrie, _ = loadEmojiOne(DictEmojiOne)
if trie, err := loadEmojiOne(DictEmojiOne); err == nil {
emojiTrie.Store(trie)
}
var be = NewEmojiEngine()
var grinnings = be.Filter(":')")
if !inStringList(grinnings, "😂") {
Expand Down
Loading