Give each engine its own key queue; serialize engine state - #612
Open
EzeriumChristinal wants to merge 2 commits into
Open
EzeriumChristinal wants to merge 2 commits into
EzeriumChristinal wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a stack with "Settle composition state on focus change, reset, disable" — merge in that order.
The key queue and its dispatch function were process-wide globals, so with two engine instances alive (Bamboo plus BambooUs, or a fresh instance after daemon re-init) the newest init received every queued keystroke. Two engines sharing the queue showed engine 1's input committing on engine 2.
Each engine now owns its queue and consumer goroutine. ProcessKeyEvent and the consumer hold the engine mutex around preeditor access; the send that can block (full queue) drops the lock across the send, so the consumer can always drain.
No new sleeps were added. Key handling serializes behind the backspace sends that were already there (20-150 ms in fallback modes); in XTestFakeKeyEventIM mode a fake-backspace roundtrip can add a bounded ~50 ms while it waits.
Tests: per-engine isolation, concurrent hammer run under -race.