fix: avoid crash when X display is unavailable - #609
Open
blackthunder0812 wants to merge 2 commits into
Open
blackthunder0812 wants to merge 2 commits into
blackthunder0812 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Display *when no X server is availableDISPLAYunsetProblem
On a pure GNOME Wayland session (
gnome-shell --no-x11),DISPLAYis unset. If GNOME window-class introspection returns no value, Bamboo falls back tox11GetFocusWindowClass().XOpenDisplay(NULL)then returnsNULL, but the code passes that pointer toXGetInputFocus(), causing the engine to crash duringFocusIn().Observed crash:
This makes GNOME appear to select Bamboo and immediately fall back to the English input source. It is especially visible in native Wayland Chromium with text-input-v3 enabled.
Verification
make testpassesmake buildpassesDISPLAYunset and successfully typed Vietnamese in native Wayland Chrome 151Related to #44, but this PR only fixes the no-X-display crash; it does not claim complete Wayland feature parity.