Skip to content

fix: add Clinical Waste bin type to Mid Suffolk and Babergh collectors - #832

Merged
BadgerHobbs merged 1 commit into
mainfrom
fix/mid-suffolk-babergh-clinical-waste
Sep 30, 2026
Merged

BadgerHobbs merged 1 commit into
mainfrom
fix/mid-suffolk-babergh-clinical-waste

Conversation

@BadgerHobbs

Copy link
Copy Markdown
Owner

Problem

Production logs on 2026-09-30 showed two Bin day on … matched no bin types and was dropped warnings for one Mid Suffolk address (IP22 area). A live replay of that address through the app's transport showed a row neither collector knows about:

'Clinical Waste' | Thursday 08 Oct 2026
'Clinical Waste' | Thursday 22 Oct 2026

The council gives eligible residents a yellow clinical waste bin, collected fortnightly, and the finder only lists it on those households' schedules. Without a key, these days were dropped. When a clinical collection shares a date with another bin, it is silently merged away with no warning at all.

Fix

Add a Clinical Waste bin type (yellow, key Clinical Waste) to MidSuffolk and BaberghDistrictCouncil. The key doesn't overlap any existing key. Version is unchanged, so saved addresses are unaffected.

Impact

The collectors only attach bins for services the council returns for that address, so only homes on the clinical waste service see the new bin. I re-fetched the live schedules of all 541 addresses looked up by users in the last 30 days (456 Mid Suffolk, 85 Babergh):

  • Every row matched an existing key except Clinical Waste (1 home) and Trade Refuse Collection (1 home, a commercial service that's intentionally left out).
  • No Babergh user address currently has clinical waste. Both sites run on the same Liferay instance (same companyId), and the Babergh site returns the identical Clinical Waste label for the affected Mid Suffolk address, so the same key applies.

Testing

  • dotnet build: 0 warnings, 0 errors. dotnet format --verify-no-changes is clean.
  • MidSuffolkTests and BaberghDistrictCouncilTests: 5/5 passed.
  • Ran the affected address once through the full API flow with a temporary pinned test (not committed). It now returns 8 bin days instead of 6, including two Clinical Waste (Yellow) days, with no dropped-bin-day warnings.

🤖 Generated with Claude Code

The shared Babergh Mid Suffolk collection day finder lists a "Clinical
Waste" row for households on the council's fortnightly clinical waste
service (a yellow bin for eligible residents). Neither collector had a
key for it, so those collection days were dropped, or silently merged
away when they shared a date with another bin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BadgerHobbs
BadgerHobbs merged commit ae369fc into main Sep 30, 2026
2 checks passed
@BadgerHobbs
BadgerHobbs deleted the fix/mid-suffolk-babergh-clinical-waste branch September 30, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant