fix: add Clinical Waste bin type to Mid Suffolk and Babergh collectors - #832
Merged
Merged
Conversation
The shared Babergh Mid Suffolk collection day finder lists a "Clinical Waste" row for households on the council's fortnightly clinical waste service (a yellow bin for eligible residents). Neither collector had a key for it, so those collection days were dropped, or silently merged away when they shared a date with another bin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Production logs on 2026-09-30 showed two
Bin day on … matched no bin types and was droppedwarnings for one Mid Suffolk address (IP22 area). A live replay of that address through the app's transport showed a row neither collector knows about:The council gives eligible residents a yellow clinical waste bin, collected fortnightly, and the finder only lists it on those households' schedules. Without a key, these days were dropped. When a clinical collection shares a date with another bin, it is silently merged away with no warning at all.
Fix
Add a
Clinical Wastebin type (yellow, keyClinical Waste) toMidSuffolkandBaberghDistrictCouncil. The key doesn't overlap any existing key.Versionis unchanged, so saved addresses are unaffected.Impact
The collectors only attach bins for services the council returns for that address, so only homes on the clinical waste service see the new bin. I re-fetched the live schedules of all 541 addresses looked up by users in the last 30 days (456 Mid Suffolk, 85 Babergh):
Clinical Waste(1 home) andTrade Refuse Collection(1 home, a commercial service that's intentionally left out).companyId), and the Babergh site returns the identicalClinical Wastelabel for the affected Mid Suffolk address, so the same key applies.Testing
dotnet build: 0 warnings, 0 errors.dotnet format --verify-no-changesis clean.MidSuffolkTestsandBaberghDistrictCouncilTests: 5/5 passed.Clinical Waste (Yellow)days, with no dropped-bin-day warnings.🤖 Generated with Claude Code