Repository navigation
Add collector for Derbyshire Dales District Council - #824
Merged
BadgerHobbs merged 7 commits intoSep 30, 2026
Merged
BadgerHobbs merged 7 commits into
BadgerHobbs merged 7 commits into
Conversation
Closes #823 Generated with Codex CLI by Moley-Bot
moley-bot
Bot
added
the
new collector
Formatted by Moley-Bot
The bin types only covered sack-collection properties, so ~90% of households (grey/blue/green wheelie bins) silently lost general waste, recycling and garden waste. Add keys for the live service names seen across a 132-address district-wide sample, rename the blue bag to a neutral "Recycling", and pin a wheelie-bin test address. Also drop the unneeded form GET before the address lookup (it works without a session) and the x-requested-with headers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Council guidance: the blue box takes glass/cans/plastics (same as the blue-lid bin's main section) and the extra blue bag is for plastic, so rename "Dry Recycling" box to "Mixed Recycling" and the "Recycling" bag to "Plastic Recycling". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MergeBinDays de-duplicates bins by Name per date, so naming both the blue-lid bin and the blue box "Mixed Recycling" dropped the bin for households that have both. Use the council's own wording for the box. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Guards against same-Name bins being de-duplicated by MergeBinDays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Flats with shared containers returned service names matching no bin type, so refuse, food, paper and glass were silently dropped, and some blocks (e.g. Chatsworth Court) failed with AllBinDaysUnmatchedException. Add keys for the 360L/660L/1100L refuse containers and distinctly named communal food, paper and glass bins, and pin a communal-only address. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BadgerHobbs
deleted the
collector/DerbyshireDalesDistrictCouncil-issue-823-1790772952
branch
September 30, 2026 21:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new bin collection data collector for Derbyshire Dales District Council.
ICollectorinterfaceCloses #823
Changes after review
The original implementation only covered sack-collection properties (the example postcode is a sack street), so most households silently lost general waste, recycling and garden waste. Bin types were rebuilt from the live service names seen across ~400 addresses sampled district-wide:
Domestic Waste 140L Bin,Domestic Waste 240L Waste BinDomestic Waste 360L/660L/1100L ContainerDomestic Waste SacksFood Waste 23L CaddyFood 240L Waste BinRecycling 240L Waste BinRecycling Blue Waste BoxPaper Waste SacksRecycling Waste SacksCommunal Paper 240L Waste BinCommunal Glass Waste 240L Waste BinGarden Waste 240L BinTrade ...services are intentionally not matched. Names are distinct for containers that can share a collection date, sinceMergeBinDaysde-duplicates by name. The address lookup is now a single request (no session needed).Pinned test addresses: sacks (DE4 3PW), standard bins + garden (DE4 2EE), blue bin + blue box (S33 9JU), communal flats (DE6 1PF). Output for each was compared date-by-date against the council website and matches.
Test Summary
Bin Collections Page Screenshot
Generated automatically by Moley-Bot using Codex CLI; revised with Claude Code.
🤖 Generated with Claude Code