Skip to content

feat: show archive storage and document S3 operations - #319

Open
renaesop wants to merge 7 commits into
BaaRai:mainfrom
renaesop:codex/s3-archive-ui-docs
Open

renaesop wants to merge 7 commits into
BaaRai:mainfrom
renaesop:codex/s3-archive-ui-docs

Conversation

@renaesop

@renaesop renaesop commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Problem and change

The archive list needs to identify the stored destination without labelling an in-progress remote upload as local. Operators also need the configuration, encryption, credential and recovery requirements for bucket archives.

The backend #285 and server integration #318 are now merged. This branch incorporates upstream 5876d51; its remaining diff contains only UI/types, translations and operator documentation.

  • Show Object storage or Local storage only for an explicit API value; omit the label while the destination is unknown or on older API responses.
  • Show readable upload/download verification phases and explain the configured archive destination and local restore-space requirement.
  • Translate the archive text in both Turkish and Simplified Chinese. Replacing the old local-only description keeps the catalogs consistent with upstream's new parity checks.
  • Document exact KMS key-ARN matching, bucket policies, DeleteObjectVersion, both credential paths honoring AWS_CA_BUNDLE, and rejection of redirects.
  • Explain startup credential capture and environment cleanup, including the separate access controls still needed for credential/token files and instance metadata.
  • Describe bounded read retries, cancellation cleanup, source retention, partial-file recovery and remaining lifecycle/version-retention requirements.

Validation

  • CI at 801b1e1 passed every job: Go (including the full race suite), stable Go, web (including the static build), Python and shell.
  • Fresh local dependencies installed from the updated lockfile with npm ci --ignore-scripts; tsc --noEmit --incremental false passed.
  • npm run test:i18n passed: 2,643 literal keys checked against 2,711 entries in each Turkish and Simplified Chinese catalog, plus locale runtime tests.
  • Local polling, replay, upload, Bash exit-status and tamper-hooks frontend tests all passed.

The unknown/local/s3 API response cases and archive lifecycle tests landed in #318. Operator documentation distinguishes isolated HTTP/PostgreSQL testing from live-cloud compatibility.

@renaesop

Copy link
Copy Markdown
Contributor Author

Updated in efe4861 and synchronized with upstream 65045ef in 52e759d.

The archive list now renders a storage label only for explicit local/s3 values, so queued/uploading archives and older responses no longer appear falsely local. Documentation matches the reviewed implementation: exact KMS key ARN, version-specific failed-upload cleanup, cancellation/abort handling, AWS_CA_BUNDLE in both credential paths, no redirects, bounded retries and .partial recovery. Crash/version-retention limits are stated explicitly.

  • Remote tsc --noEmit --incremental false passed.
  • CI at 52e759d passed every job.
  • UI/docs are included in the tested integration c0bbed6, whose archive-related race tests, full server/db suites, build, vet and dependency checks passed.

This stays draft pending #318 and #285.

@renaesop
renaesop force-pushed the codex/s3-archive-ui-docs branch from 52e759d to b422eb9 Compare November 20, 2026 02:09
…-docs

# Conflicts:
#	README.md
#	web/src/app/(main)/function/tasks/page.tsx
@renaesop

Copy link
Copy Markdown
Contributor Author

Synchronized with upstream 705ac80 in af68f44 and resolved the README/task-page conflicts.

The archive descriptions, storage labels and upload/download phases now use upstream's translation layer, with Turkish dictionary entries. Existing translated task-page behavior and the upstream gateway documentation are preserved.

  • CI at af68f44 passed every job: Go (including the full race suite), stable Go, web, Python and shell.
  • On shein-artex, node scripts/check-i18n.mjs passed (2,546 literal keys checked against 2,604 dictionary entries).
  • tsc --noEmit --incremental false passed.
  • The task-page merge was checked against current upstream translations, including the archive destination, storage labels and both verification phases.

There are currently no new reviewer comments on this PR. It remains draft because server integration #318 still needs to land; #285 is already merged.

@renaesop

Copy link
Copy Markdown
Contributor Author

Synced this UI/docs branch with upstream 9465dfa in 811c2e4. The latest traffic/HAR and translation changes merge cleanly; the archive UI behavior remains unchanged.

  • CI at 811c2e4 passed every job: Go (including the full race suite), stable Go, web, Python and shell.
  • node scripts/check-i18n.mjs passed: 2,566 literal keys checked against 2,624 dictionary entries.
  • tsc --noEmit --incremental false passed.

This stays draft pending #318. The server follow-up includes the newly required startup credential-ordering fix and restore API adaptation.

@renaesop
renaesop marked this pull request as ready for review November 21, 2026 03:08
@renaesop

Copy link
Copy Markdown
Contributor Author

#318 has merged, so both backend dependencies (#285 and #318) are now available on main. Synced this branch with upstream 5876d51 in d8f8f6c.

The sync exposed a real frontend check failure: upstream now ships Simplified Chinese and checks dictionary parity. This branch's five archive strings had no Chinese translations, and its obsolete local-only description remained in that catalog. Fixed both in 801b1e1; the updated catalogs now pass the same coverage and parity check.

Also documented the merged server's startup credential capture/scrubbing behavior and its limits for shared credential files, token files and instance metadata. The remaining PR diff is limited to six UI/types, translation and documentation files.

  • CI at 801b1e1 passed every job: Go (including the full race suite), stable Go, web (including the static build), Python and shell.
  • Fresh local dependencies installed from the updated lockfile with npm ci --ignore-scripts; tsc --noEmit --incremental false passed.
  • npm run test:i18n passed: 2,643 literal keys checked against 2,711 entries in each Turkish and Simplified Chinese catalog, plus locale runtime tests.
  • Local polling, replay, upload, Bash exit-status and tamper-hooks frontend tests all passed.

The dependency hold is resolved; this PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant